[PR #3139] [MERGED] Minor refactoring concering user.setpassword #3229

New issue

Closed

opened 2026-03-03 09:42:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:42:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3139
Author: @sirux88
Created: 1/13/2023
Status: ✅ Merged
Merged: 1/24/2023
Merged by: @dani-garcia

Base: main ← Head: refactoring-user-setpassword

📝 Commits (3)

f8122cd include key into user.set_password
623d84a include key into user.set_password
906d9e2 Merge branch 'refactoring-user-setpassword' of https://github.com/sirux88/vaultwarden into refactoring-user-setpassword

📊 Changes

3 files changed (+11 additions, -12 deletions)

View changed files

📝 src/api/core/accounts.rs (+6 -7)
📝 src/api/core/emergency_access.rs (+2 -3)
📝 src/db/models/user.rs (+3 -2)

📄 Description

Setting a new users password hash always requires setting a new key value aswell
Therefore I refactored the specific method user.set_password and all corresponding usages

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3139 **Author:** [@sirux88](https://github.com/sirux88) **Created:** 1/13/2023 **Status:** ✅ Merged **Merged:** 1/24/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `refactoring-user-setpassword` --- ### 📝 Commits (3) - [`f8122cd`](https://github.com/dani-garcia/vaultwarden/commit/f8122cd2cad64c27d9d1d3aed34f839b39bdfec0) include key into user.set_password - [`623d84a`](https://github.com/dani-garcia/vaultwarden/commit/623d84aeb5b150f38f9e9443a965b1a34841602f) include key into user.set_password - [`906d9e2`](https://github.com/dani-garcia/vaultwarden/commit/906d9e2f1acc94795a8052d8ec0e80c8e47d787a) Merge branch 'refactoring-user-setpassword' of https://github.com/sirux88/vaultwarden into refactoring-user-setpassword ### 📊 Changes **3 files changed** (+11 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+6 -7) 📝 `src/api/core/emergency_access.rs` (+2 -3) 📝 `src/db/models/user.rs` (+3 -2) </details> ### 📄 Description Setting a new users password hash always requires setting a new key value aswell Therefore I refactored the specific method user.set_password and all corresponding usages --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>