[PR #3076] [MERGED] Update WebSocket Notifications #3213

New issue

Closed

opened 2026-03-03 09:41:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:41:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3076
Author: @BlackDex
Created: 12/30/2022
Status: ✅ Merged
Merged: 1/9/2023
Merged by: @dani-garcia

Base: main ← Head: update-notifications

📝 Commits (1)

996b60e Update WebSocket Notifications

📊 Changes

8 files changed (+188 additions, -64 deletions)

View changed files

📝 src/api/admin.rs (+13 -5)
📝 src/api/core/accounts.rs (+39 -8)
📝 src/api/core/ciphers.rs (+56 -17)
📝 src/api/core/folders.rs (+3 -3)
📝 src/api/core/mod.rs (+18 -9)
📝 src/api/core/organizations.rs (+24 -6)
📝 src/api/core/sends.rs (+6 -0)
📝 src/api/notifications.rs (+29 -16)

📄 Description

Previously the websocket notifications were using the string app_id as the
ContextId. This was incorrect and should have been the device_uuid
from the client device executing the request. The clients will ignore
the websocket request if the uuid matches. This also fixes some issues
with the Desktop client which is able to modify attachments within the
same screen and causes an issue when saving the attachment afterwards.

Also changed the way to handle removed attachments, since that causes an
error saving the vault cipher afterwards, complaining about a missing
attachment. Bitwarden ignores this, and continues with the remaining
attachments (if any). This also fixes #2591 .

Further some more websocket notifications have been added to some other
functions which enhance the user experience.

Logout users when deauthed, changed password, rotated keys
Trigger OrgSyncKeys on user confirm and removal
Added some extra to the send feature

Also renamed UpdateTypes to match Bitwarden naming.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3076 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 12/30/2022 **Status:** ✅ Merged **Merged:** 1/9/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `update-notifications` --- ### 📝 Commits (1) - [`996b60e`](https://github.com/dani-garcia/vaultwarden/commit/996b60e43d5db7149263a7c5a5b1c9e9725f1f00) Update WebSocket Notifications ### 📊 Changes **8 files changed** (+188 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+13 -5) 📝 `src/api/core/accounts.rs` (+39 -8) 📝 `src/api/core/ciphers.rs` (+56 -17) 📝 `src/api/core/folders.rs` (+3 -3) 📝 `src/api/core/mod.rs` (+18 -9) 📝 `src/api/core/organizations.rs` (+24 -6) 📝 `src/api/core/sends.rs` (+6 -0) 📝 `src/api/notifications.rs` (+29 -16) </details> ### 📄 Description Previously the websocket notifications were using the string `app_id` as the `ContextId`. This was incorrect and should have been the device_uuid from the client device executing the request. The clients will ignore the websocket request if the uuid matches. This also fixes some issues with the Desktop client which is able to modify attachments within the same screen and causes an issue when saving the attachment afterwards. Also changed the way to handle removed attachments, since that causes an error saving the vault cipher afterwards, complaining about a missing attachment. Bitwarden ignores this, and continues with the remaining attachments (if any). This also fixes #2591 . Further some more websocket notifications have been added to some other functions which enhance the user experience. - Logout users when deauthed, changed password, rotated keys - Trigger OrgSyncKeys on user confirm and removal - Added some extra to the send feature Also renamed UpdateTypes to match Bitwarden naming. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>