[PR #2995] [MERGED] Disable groups by default and Some optimizations #3204

New issue

Closed

opened 2026-03-03 09:41:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:41:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2995
Author: @BlackDex
Created: 12/15/2022
Status: ✅ Merged
Merged: 12/18/2022
Merged by: @dani-garcia

Base: main ← Head: some-optimizations

📝 Commits (1)

8b6dfe4 Disable groups by default and Some optimizations

📊 Changes

35 files changed (+230 additions, -95 deletions)

View changed files

📝 .env.template (+7 -0)
📝 .github/workflows/build.yml (+3 -2)
📝 .github/workflows/hadolint.yml (+3 -2)
📝 .github/workflows/release.yml (+3 -2)
📝 .pre-commit-config.yaml (+2 -2)
📝 Cargo.lock (+16 -25)
📝 Cargo.toml (+2 -2)
📝 docker/Dockerfile.j2 (+9 -9)
📝 docker/amd64/Dockerfile (+1 -1)
📝 docker/amd64/Dockerfile.alpine (+2 -2)
📝 docker/amd64/Dockerfile.buildx (+1 -1)
📝 docker/amd64/Dockerfile.buildx.alpine (+2 -2)
📝 docker/arm64/Dockerfile (+1 -1)
📝 docker/arm64/Dockerfile.alpine (+2 -2)
📝 docker/arm64/Dockerfile.buildx (+1 -1)
📝 docker/arm64/Dockerfile.buildx.alpine (+2 -2)
📝 docker/armv6/Dockerfile (+1 -1)
📝 docker/armv6/Dockerfile.alpine (+2 -2)
📝 docker/armv6/Dockerfile.buildx (+1 -1)
📝 docker/armv6/Dockerfile.buildx.alpine (+2 -2)

...and 15 more files

📄 Description

Put groups support behind a feature flag, and disabled by default. The reason is that it has some known issues, but we want to keep optimizing this feature. Putting it behind a feature flag could help some users, and the developers into optimizing this feature without to much trouble.

Further:

Updated jquery to v3.6.2
Moved jdenticon.js to load at the bottom, fixes an issue on chromium
Added autocomplete attribute to admin login password field
Added some extra CSP options (Tested this on Safari, Firefox, Chrome, Bitwarden Desktop)
Moved uppercase convertion from runtime to compile-time using paste for building the environment variables, lowers heap allocations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2995 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 12/15/2022 **Status:** ✅ Merged **Merged:** 12/18/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `some-optimizations` --- ### 📝 Commits (1) - [`8b6dfe4`](https://github.com/dani-garcia/vaultwarden/commit/8b6dfe48b70909caea0c8a4bf51bc89a451b766a) Disable groups by default and Some optimizations ### 📊 Changes **35 files changed** (+230 additions, -95 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+7 -0) 📝 `.github/workflows/build.yml` (+3 -2) 📝 `.github/workflows/hadolint.yml` (+3 -2) 📝 `.github/workflows/release.yml` (+3 -2) 📝 `.pre-commit-config.yaml` (+2 -2) 📝 `Cargo.lock` (+16 -25) 📝 `Cargo.toml` (+2 -2) 📝 `docker/Dockerfile.j2` (+9 -9) 📝 `docker/amd64/Dockerfile` (+1 -1) 📝 `docker/amd64/Dockerfile.alpine` (+2 -2) 📝 `docker/amd64/Dockerfile.buildx` (+1 -1) 📝 `docker/amd64/Dockerfile.buildx.alpine` (+2 -2) 📝 `docker/arm64/Dockerfile` (+1 -1) 📝 `docker/arm64/Dockerfile.alpine` (+2 -2) 📝 `docker/arm64/Dockerfile.buildx` (+1 -1) 📝 `docker/arm64/Dockerfile.buildx.alpine` (+2 -2) 📝 `docker/armv6/Dockerfile` (+1 -1) 📝 `docker/armv6/Dockerfile.alpine` (+2 -2) 📝 `docker/armv6/Dockerfile.buildx` (+1 -1) 📝 `docker/armv6/Dockerfile.buildx.alpine` (+2 -2) _...and 15 more files_ </details> ### 📄 Description - Put groups support behind a feature flag, and disabled by default. The reason is that it has some known issues, but we want to keep optimizing this feature. Putting it behind a feature flag could help some users, and the developers into optimizing this feature without to much trouble. Further: - Updated jquery to v3.6.2 - Moved jdenticon.js to load at the bottom, fixes an issue on chromium - Added autocomplete attribute to admin login password field - Added some extra CSP options (Tested this on Safari, Firefox, Chrome, Bitwarden Desktop) - Moved uppercase convertion from runtime to compile-time using `paste` for building the environment variables, lowers heap allocations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>