[PR #2976] [MERGED] Revert collection queries back to `left_join` #3203

New issue

Closed

opened 2026-03-03 09:41:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:41:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2976
Author: @BlackDex
Created: 12/12/2022
Status: ✅ Merged
Merged: 12/12/2022
Merged by: @dani-garcia

Base: main ← Head: issue-2975

📝 Commits (1)

d9c0c23 Revert collection queries back to left_join

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 src/db/models/collection.rs (+6 -6)

📄 Description

Using the inner_join seems to cause issues, even though i have tested it. Strangely it does cause issues. Reverting it back to left_join seems to solve the issue for me.

Fixes #2975

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2976 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 12/12/2022 **Status:** ✅ Merged **Merged:** 12/12/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `issue-2975` --- ### 📝 Commits (1) - [`d9c0c23`](https://github.com/dani-garcia/vaultwarden/commit/d9c0c23819fdd327750931103a1ec3e625a257a4) Revert collection queries back to `left_join` ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/db/models/collection.rs` (+6 -6) </details> ### 📄 Description Using the `inner_join` seems to cause issues, even though i have tested it. Strangely it does cause issues. Reverting it back to `left_join` seems to solve the issue for me. Fixes #2975 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>