mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[PR #2918] [MERGED] Set "Bypass admin page security" as read-only #3183
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#3183
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/2918
Author: @BlackDex
Created: 11/14/2022
Status: ✅ Merged
Merged: 11/27/2022
Merged by: @dani-garcia
Base:
main← Head:issue-2761📝 Commits (1)
b141f78Set "Bypass admin page security" as read-only📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
src/config.rs(+1 -1)📄 Description
It was possible to disable the admin security via the admin interface. This is kinda insecure as mentioned in #2761.
This PR set this value as read-only and admin's need to set the correct ENV variable. Currently saved settings which do override this are still valid though. If an admin want's this removed, they either need to reset the config, or change the value in the
config.jsonfile.Fixes #2761
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.