[PR #2877] [CLOSED] make support string more secure #3173

Closed
opened 2026-03-03 09:41:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2877
Author: @tessus
Created: 10/31/2022
Status: Closed

Base: mainHead: fix/privacy-mask


📝 Commits (1)

  • fc79c47 make support string more secure

📊 Changes

1 file changed (+1 additions, -14 deletions)

View changed files

📝 src/config.rs (+1 -14)

📄 Description

When a support string is generated the masked entries still show certain info:

  • length of a password, user, database name in the DB URL
  • length of smtp username
  • domain length and TLD length, if subdomain is used or a sub directory
  • length and format of smtp_from

This change masks the fields with *** as it is done for passwords.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2877 **Author:** [@tessus](https://github.com/tessus) **Created:** 10/31/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/privacy-mask` --- ### 📝 Commits (1) - [`fc79c47`](https://github.com/dani-garcia/vaultwarden/commit/fc79c47d82df03369ad580935154d15643ee3b33) make support string more secure ### 📊 Changes **1 file changed** (+1 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/config.rs` (+1 -14) </details> ### 📄 Description When a support string is generated the masked entries still show certain info: - length of a password, user, database name in the DB URL - length of smtp username - domain length and TLD length, if subdomain is used or a sub directory - length and format of smtp_from This change masks the fields with `***` as it is done for passwords. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:41:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3173
No description provided.