mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[PR #2772] [MERGED] allow the removal of non-confirmed owners #3146
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#3146
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/2772
Author: @stefan0xC
Created: 9/27/2022
Status: ✅ Merged
Merged: 10/9/2022
Merged by: @dani-garcia
Base:
main← Head:allow-removal-of-invited-owners📝 Commits (1)
2685099allow the removal of non-confirmed owners📊 Changes
1 file changed (+6 additions, -3 deletions)
View changed files
📝
src/api/core/organizations.rs(+6 -3)📄 Description
If you invite a new user as another owner of an organization you cannot remove or change the role of the user until the user accepts the invitation and is confirmed. This behavior was introduced in
1722742a(previously, in 1.25.2 you could remove yourself as the owner as long as you had invited someone else as owner which would also be incorrect).This change ensures user_to_edit and user_to_delete are actually confirmed users, before checking if they are the last owner of an organization.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.