[PR #2292] [MERGED] Update async to prepare for main merge + several updates #3077

New issue

Closed

opened 2026-03-03 09:25:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:25:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2292
Author: @BlackDex
Created: 2/7/2022
Status: ✅ Merged
Merged: 2/27/2022
Merged by: @dani-garcia

Base: async ← Head: async-updates

📝 Commits (2)

5f01db6 Update async to prepare for main merge
42136a7 Favicon, SMTP and misc updates

📊 Changes

36 files changed (+4858 additions, -2417 deletions)

View changed files

📝 .dockerignore (+15 -2)
📝 .env.template (+1 -2)
📝 .github/workflows/build.yml (+11 -11)
📝 .github/workflows/hadolint.yml (+2 -2)
📝 .github/workflows/release.yml (+2 -2)
📝 .pre-commit-config.yaml (+1 -1)
📝 Cargo.lock (+485 -312)
📝 Cargo.toml (+57 -56)
📝 docker/Dockerfile.buildx (+1 -0)
📝 docker/Dockerfile.j2 (+7 -13)
📝 docker/amd64/Dockerfile (+3 -3)
📝 docker/amd64/Dockerfile.alpine (+3 -3)
📝 docker/amd64/Dockerfile.buildx (+3 -3)
📝 docker/amd64/Dockerfile.buildx.alpine (+3 -3)
📝 docker/arm64/Dockerfile (+3 -3)
📝 docker/arm64/Dockerfile.alpine (+3 -3)
📝 docker/arm64/Dockerfile.buildx (+3 -3)
📝 docker/arm64/Dockerfile.buildx.alpine (+3 -3)
📝 docker/armv6/Dockerfile (+3 -3)
📝 docker/armv6/Dockerfile.alpine (+3 -3)

...and 16 more files

📄 Description

Async Update:

Changed nightly to stable in Dockerfile and Workflow
Updated Dockerfile to use stable and updated ENV's
Removed 0.0.0.0 as default addr it now uses ROCKET_ADDRESS or the default
Updated Github Workflow actions to the latest versions
Updated Hadolint version
Re-orderd the Cargo.toml file a bit and put libs together which are linked
Updated some libs
Updated .dockerignore file

Favicon, SMTP and misc updates:

Favicon:

Replaced HTML tokenizer, much faster now.
Caching the domain blacklist function.
Almost all functions are async now.
Fixed bug on minimizing data to parse
Changed maximum icon download size to 5MB to match Bitwarden
Added apple-touch-icon.png as a second fallback besides favicon.ico

SMTP:

Deprecated SMTP_SSL and SMTP_EXPLICIT_TLS, replaced with SMTP_SECURITY

Misc:

Fixed issue when resolv.conf contains errors and trust-dns panics (Fixes #2283)
Updated Javscript and CSS files for admin interface
Fixed an issue with the /admin interface which did not cleared the login cookie correctly on logout
Prevent websocket notifications during org import, this caused a lot of traffic, and slowed down the import.
This is also the same as Bitwarden which does not trigger this refresh via websockets.

Rust:

Updated to use v1.59
Use the new strip option and enabled to strip debuginfo
Enabled lto with thin
Removed the strip RUN from the alpine armv7, this is now done automatically

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2292 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 2/7/2022 **Status:** ✅ Merged **Merged:** 2/27/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `async` ← **Head:** `async-updates` --- ### 📝 Commits (2) - [`5f01db6`](https://github.com/dani-garcia/vaultwarden/commit/5f01db69ffdb3d37e24e30a7003792ed72882973) Update async to prepare for main merge - [`42136a7`](https://github.com/dani-garcia/vaultwarden/commit/42136a70973f60086749c62439c6a965d4589c02) Favicon, SMTP and misc updates ### 📊 Changes **36 files changed** (+4858 additions, -2417 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+15 -2) 📝 `.env.template` (+1 -2) 📝 `.github/workflows/build.yml` (+11 -11) 📝 `.github/workflows/hadolint.yml` (+2 -2) 📝 `.github/workflows/release.yml` (+2 -2) 📝 `.pre-commit-config.yaml` (+1 -1) 📝 `Cargo.lock` (+485 -312) 📝 `Cargo.toml` (+57 -56) 📝 `docker/Dockerfile.buildx` (+1 -0) 📝 `docker/Dockerfile.j2` (+7 -13) 📝 `docker/amd64/Dockerfile` (+3 -3) 📝 `docker/amd64/Dockerfile.alpine` (+3 -3) 📝 `docker/amd64/Dockerfile.buildx` (+3 -3) 📝 `docker/amd64/Dockerfile.buildx.alpine` (+3 -3) 📝 `docker/arm64/Dockerfile` (+3 -3) 📝 `docker/arm64/Dockerfile.alpine` (+3 -3) 📝 `docker/arm64/Dockerfile.buildx` (+3 -3) 📝 `docker/arm64/Dockerfile.buildx.alpine` (+3 -3) 📝 `docker/armv6/Dockerfile` (+3 -3) 📝 `docker/armv6/Dockerfile.alpine` (+3 -3) _...and 16 more files_ </details> ### 📄 Description **Async Update:** - Changed nightly to stable in Dockerfile and Workflow - Updated Dockerfile to use stable and updated ENV's - Removed 0.0.0.0 as default addr it now uses ROCKET_ADDRESS or the default - Updated Github Workflow actions to the latest versions - Updated Hadolint version - Re-orderd the Cargo.toml file a bit and put libs together which are linked - Updated some libs - Updated .dockerignore file **Favicon, SMTP and misc updates:** **Favicon:** - Replaced HTML tokenizer, much faster now. - Caching the domain blacklist function. - Almost all functions are async now. - Fixed bug on minimizing data to parse - Changed maximum icon download size to 5MB to match Bitwarden - Added `apple-touch-icon.png` as a second fallback besides `favicon.ico` **SMTP:** - Deprecated SMTP_SSL and SMTP_EXPLICIT_TLS, replaced with SMTP_SECURITY **Misc:** - Fixed issue when `resolv.conf` contains errors and trust-dns panics (Fixes #2283) - Updated Javscript and CSS files for admin interface - Fixed an issue with the /admin interface which did not cleared the login cookie correctly on logout - Prevent websocket notifications during org import, this caused a lot of traffic, and slowed down the import. This is also the same as Bitwarden which does not trigger this refresh via websockets. **Rust:** - Updated to use v1.59 - Use the new `strip` option and enabled to strip `debuginfo` - Enabled `lto` with `thin` - Removed the strip RUN from the alpine armv7, this is now done automatically --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>