[PR #2188] [MERGED] Add config option to set the HTTP redirect code for external icons #3065

Closed
opened 2026-03-03 09:25:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2188
Author: @jjlin
Created: 12/30/2021
Status: Merged
Merged: 1/2/2022
Merged by: @dani-garcia

Base: mainHead: icons


📝 Commits (1)

  • b7eedbc Add config option to set the HTTP redirect code for external icons

📊 Changes

3 files changed (+28 additions, -3 deletions)

View changed files

📝 .env.template (+8 -1)
📝 src/api/icons.rs (+8 -1)
📝 src/config.rs (+12 -1)

📄 Description

The default code is 307 (temporary) to make it easier to test different icon services, but once a service has been decided on, users should ideally switch to using permanent redirects for cacheability.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2188 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 12/30/2021 **Status:** ✅ Merged **Merged:** 1/2/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `icons` --- ### 📝 Commits (1) - [`b7eedbc`](https://github.com/dani-garcia/vaultwarden/commit/b7eedbcddc5bc52391472329fa6a43a2c9ae0a94) Add config option to set the HTTP redirect code for external icons ### 📊 Changes **3 files changed** (+28 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+8 -1) 📝 `src/api/icons.rs` (+8 -1) 📝 `src/config.rs` (+12 -1) </details> ### 📄 Description The default code is 307 (temporary) to make it easier to test different icon services, but once a service has been decided on, users should ideally switch to using permanent redirects for cacheability. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:25:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3065
No description provided.