[PR #2103] [MERGED] Async/Awaited all db methods #3055

New issue

Closed

opened 2026-03-03 09:25:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:25:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2103
Author: @BlackDex
Created: 11/16/2021
Status: ✅ Merged
Merged: 11/21/2021
Merged by: @dani-garcia

Base: async ← Head: async-chores

📝 Commits (2)

b36129a Async/Awaited all db methods
fb801c9 Upd Dockerfiles, crates. Fixed rust 2018 idioms

📊 Changes

52 files changed (+1525 additions, -1261 deletions)

View changed files

📝 Cargo.lock (+30 -29)
📝 Cargo.toml (+8 -8)
📝 docker/Dockerfile.j2 (+6 -3)
📝 docker/amd64/Dockerfile (+5 -2)
📝 docker/amd64/Dockerfile.alpine (+5 -2)
📝 docker/amd64/Dockerfile.buildx (+5 -2)
📝 docker/amd64/Dockerfile.buildx.alpine (+5 -2)
📝 docker/arm64/Dockerfile (+5 -2)
📝 docker/arm64/Dockerfile.buildx (+5 -2)
📝 docker/armv6/Dockerfile (+5 -2)
📝 docker/armv6/Dockerfile.buildx (+5 -2)
📝 docker/armv7/Dockerfile (+5 -2)
📝 docker/armv7/Dockerfile.alpine (+4 -1)
📝 docker/armv7/Dockerfile.buildx (+5 -2)
📝 docker/armv7/Dockerfile.buildx.alpine (+4 -1)
📝 rustfmt.toml (+4 -4)
📝 src/api/admin.rs (+80 -73)
📝 src/api/core/accounts.rs (+55 -57)
📝 src/api/core/ciphers.rs (+289 -201)
📝 src/api/core/emergency_access.rs (+123 -93)

...and 32 more files

📄 Description

This is a rather large PR which updates the async branch to have all the
database methods as an async fn.

Some iter/map logic needed to be changed to a stream::iter().then(), but
besides that most changes were just adding async/await where needed.

Also updated the libraries to the latest available while at it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2103 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 11/16/2021 **Status:** ✅ Merged **Merged:** 11/21/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `async` ← **Head:** `async-chores` --- ### 📝 Commits (2) - [`b36129a`](https://github.com/dani-garcia/vaultwarden/commit/b36129a6a5b900d2c6b0e365bef9977a04692235) Async/Awaited all db methods - [`fb801c9`](https://github.com/dani-garcia/vaultwarden/commit/fb801c95d418dcf67c082b9a96317ccde8a4086f) Upd Dockerfiles, crates. Fixed rust 2018 idioms ### 📊 Changes **52 files changed** (+1525 additions, -1261 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+30 -29) 📝 `Cargo.toml` (+8 -8) 📝 `docker/Dockerfile.j2` (+6 -3) 📝 `docker/amd64/Dockerfile` (+5 -2) 📝 `docker/amd64/Dockerfile.alpine` (+5 -2) 📝 `docker/amd64/Dockerfile.buildx` (+5 -2) 📝 `docker/amd64/Dockerfile.buildx.alpine` (+5 -2) 📝 `docker/arm64/Dockerfile` (+5 -2) 📝 `docker/arm64/Dockerfile.buildx` (+5 -2) 📝 `docker/armv6/Dockerfile` (+5 -2) 📝 `docker/armv6/Dockerfile.buildx` (+5 -2) 📝 `docker/armv7/Dockerfile` (+5 -2) 📝 `docker/armv7/Dockerfile.alpine` (+4 -1) 📝 `docker/armv7/Dockerfile.buildx` (+5 -2) 📝 `docker/armv7/Dockerfile.buildx.alpine` (+4 -1) 📝 `rustfmt.toml` (+4 -4) 📝 `src/api/admin.rs` (+80 -73) 📝 `src/api/core/accounts.rs` (+55 -57) 📝 `src/api/core/ciphers.rs` (+289 -201) 📝 `src/api/core/emergency_access.rs` (+123 -93) _...and 32 more files_ </details> ### 📄 Description This is a rather large PR which updates the async branch to have all the database methods as an async fn. Some iter/map logic needed to be changed to a stream::iter().then(), but besides that most changes were just adding async/await where needed. Also updated the libraries to the latest available while at it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>