[PR #2033] [MERGED] 2FA org policy: do not enforce on invited (not accepted) users #3047

New issue

Closed

opened 2026-03-03 09:25:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:25:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2033
Author: @domdomegg
Created: 10/9/2021
Status: ✅ Merged
Merged: 10/18/2021
Merged by: @dani-garcia

Base: main ← Head: domdomegg/2fa-check-accepted

📝 Commits (2)

a984dbb 2FA org policy: do not enforce on invited (not accepted) users
4cebe1f cargo fmt

📊 Changes

1 file changed (+12 additions, -7 deletions)

View changed files

📝 src/api/core/organizations.rs (+12 -7)

📄 Description

As per the issue raised by @jjlin in https://github.com/dani-garcia/vaultwarden/pull/1991#discussion_r720706163, we should only enforce org policies on accepted or confirmed members, and not just invited members.

I've also added explanatory comments, as well as updated the variable names according to the feedback given in https://github.com/dani-garcia/vaultwarden/pull/1991#discussion_r719133373

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2033 **Author:** [@domdomegg](https://github.com/domdomegg) **Created:** 10/9/2021 **Status:** ✅ Merged **Merged:** 10/18/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `domdomegg/2fa-check-accepted` --- ### 📝 Commits (2) - [`a984dbb`](https://github.com/dani-garcia/vaultwarden/commit/a984dbbdf3d158323dec798b0becedc3f58f6d42) 2FA org policy: do not enforce on invited (not accepted) users - [`4cebe1f`](https://github.com/dani-garcia/vaultwarden/commit/4cebe1fff457515c4e35790b3637c1112fc5a390) cargo fmt ### 📊 Changes **1 file changed** (+12 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/organizations.rs` (+12 -7) </details> ### 📄 Description As per the issue raised by @jjlin in https://github.com/dani-garcia/vaultwarden/pull/1991#discussion_r720706163, we should only enforce org policies on accepted or confirmed members, and not just invited members. I've also added explanatory comments, as well as updated the variable names according to the feedback given in https://github.com/dani-garcia/vaultwarden/pull/1991#discussion_r719133373 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>