[PR #2027] [MERGED] Fix error reporting in admin and some small fixes #3044

New issue

Closed

opened 2026-03-03 09:25:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:25:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2027
Author: @BlackDex
Created: 10/7/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @dani-garcia

Base: main ← Head: mail-errors

📝 Commits (1)

3387565 Fix error reporting in admin and some small fixes

📊 Changes

8 files changed (+52 additions, -24 deletions)

View changed files

📝 src/api/admin.rs (+5 -1)
📝 src/mail.rs (+18 -5)
📝 src/static/templates/admin/base.hbs (+4 -4)
📝 src/static/templates/admin/diagnostics.hbs (+2 -2)
📝 src/static/templates/admin/organizations.hbs (+2 -2)
📝 src/static/templates/admin/settings.hbs (+3 -4)
📝 src/static/templates/admin/users.hbs (+6 -6)
📝 src/util.rs (+12 -0)

📄 Description

Fixed a bug in JavaScript which caused no messages to be shown to the
user in-case of an error send by the server.
Changed mail error handling for better error messages
Changed user/org actions from a to buttons, this should prevent
strange issues in-case of javascript issues and the page does re-load.
Added Alpine and Debian info for the running docker image

During the mail error testing i encountered a bug which caused lettre to
panic. This panic only happens on debug builds and not release builds,
so no need to update anything on that part. This bug is also already
fixed. See https://github.com/lettre/lettre/issues/678 and https://github.com/lettre/lettre/pull/679

Resolves #2021
Could also fix the issue reported here #2022, or at least no hash # in
the url.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2027 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 10/7/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `mail-errors` --- ### 📝 Commits (1) - [`3387565`](https://github.com/dani-garcia/vaultwarden/commit/338756550a27d1084ae947a1a108482abb8f473b) Fix error reporting in admin and some small fixes ### 📊 Changes **8 files changed** (+52 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+5 -1) 📝 `src/mail.rs` (+18 -5) 📝 `src/static/templates/admin/base.hbs` (+4 -4) 📝 `src/static/templates/admin/diagnostics.hbs` (+2 -2) 📝 `src/static/templates/admin/organizations.hbs` (+2 -2) 📝 `src/static/templates/admin/settings.hbs` (+3 -4) 📝 `src/static/templates/admin/users.hbs` (+6 -6) 📝 `src/util.rs` (+12 -0) </details> ### 📄 Description - Fixed a bug in JavaScript which caused no messages to be shown to the user in-case of an error send by the server. - Changed mail error handling for better error messages - Changed user/org actions from a to buttons, this should prevent strange issues in-case of javascript issues and the page does re-load. - Added Alpine and Debian info for the running docker image During the mail error testing i encountered a bug which caused lettre to panic. This panic only happens on debug builds and not release builds, so no need to update anything on that part. This bug is also already fixed. See https://github.com/lettre/lettre/issues/678 and https://github.com/lettre/lettre/pull/679 Resolves #2021 Could also fix the issue reported here #2022, or at least no hash `#` in the url. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>