[PR #1700] [MERGED] Fix attachment downloads #2997

Closed
opened 2026-03-03 09:09:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1700
Author: @jjlin
Created: 5/16/2021
Status: Merged
Merged: 5/16/2021
Merged by: @dani-garcia

Base: mainHead: fix-attachment-downloads


📝 Commits (2)

📊 Changes

3 files changed (+15 additions, -4 deletions)

View changed files

📝 src/api/admin.rs (+2 -1)
📝 src/api/core/ciphers.rs (+10 -0)
📝 src/api/web.rs (+3 -3)

📄 Description

Upstream switched to new upload/download APIs. Uploads fall back to the
legacy APIs for now, but not downloads apparently.

Fixes #1697.

Upstream PR: https://github.com/bitwarden/server/pull/1153


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1700 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 5/16/2021 **Status:** ✅ Merged **Merged:** 5/16/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-attachment-downloads` --- ### 📝 Commits (2) - [`38104ba`](https://github.com/dani-garcia/vaultwarden/commit/38104ba7cfdf6583b3efd3a67134d88d81af3f41) `cargo fmt` changes - [`9133e29`](https://github.com/dani-garcia/vaultwarden/commit/9133e2927d3189804431aa013bff2cf14fc812fb) Fix attachment downloads ### 📊 Changes **3 files changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+2 -1) 📝 `src/api/core/ciphers.rs` (+10 -0) 📝 `src/api/web.rs` (+3 -3) </details> ### 📄 Description Upstream switched to new upload/download APIs. Uploads fall back to the legacy APIs for now, but not downloads apparently. Fixes #1697. Upstream PR: https://github.com/bitwarden/server/pull/1153 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:09:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#2997
No description provided.