[PR #1262] [MERGED] Updated icon downloading. #2932

New issue

Closed

opened 2026-03-03 09:09:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:09:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1262
Author: @BlackDex
Created: 12/8/2020
Status: ✅ Merged
Merged: 12/8/2020
Merged by: @dani-garcia

Base: master ← Head: icon-fixes

📝 Commits (1)

48baf72 Updated icon downloading

📊 Changes

4 files changed (+138 additions, -40 deletions)

View changed files

📝 .env.template (+2 -1)
📝 src/api/icons.rs (+123 -39)
📝 src/config.rs (+10 -0)
📝 src/main.rs (+3 -0)

📄 Description

Added more checks to prevent panics (Removed unwrap)
Try do download from base domain or add www when the provided domain
fails
Added some more domain validation checks to prevent errors
Added the ICON_BLACKLIST_REGEX to a Lazy Static HashMap which
speeds-up the checks!
Validate the Regex before starting/config change.
Some cleanups
Disabled some noisy debugging from 2 crates.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1262 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 12/8/2020 **Status:** ✅ Merged **Merged:** 12/8/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `icon-fixes` --- ### 📝 Commits (1) - [`48baf72`](https://github.com/dani-garcia/vaultwarden/commit/48baf723a422f0a4964807b12b002a589799d6ee) Updated icon downloading ### 📊 Changes **4 files changed** (+138 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+2 -1) 📝 `src/api/icons.rs` (+123 -39) 📝 `src/config.rs` (+10 -0) 📝 `src/main.rs` (+3 -0) </details> ### 📄 Description - Added more checks to prevent panics (Removed unwrap) - Try do download from base domain or add www when the provided domain fails - Added some more domain validation checks to prevent errors - Added the ICON_BLACKLIST_REGEX to a Lazy Static HashMap which speeds-up the checks! - Validate the Regex before starting/config change. - Some cleanups - Disabled some noisy debugging from 2 crates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>