[PR #1257] [MERGED] Validate cipher updates with revision date #2930

New issue

Closed

opened 2026-03-03 09:08:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:08:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1257
Author: @jjlin
Created: 12/6/2020
Status: ✅ Merged
Merged: 12/8/2020
Merged by: @dani-garcia

Base: master ← Head: cipher-rev-date

📝 Commits (1)

a9e9a39 Validate cipher updates with revision date

📊 Changes

1 file changed (+21 additions, -1 deletions)

View changed files

📝 src/api/core/ciphers.rs (+21 -1)

📄 Description

Prevent clients from updating a cipher if the local copy is stale.
Validation is only performed when the client provides its last known
revision date; this date isn't provided when using older clients,
or when the operation doesn't involve updating an existing cipher.

Fixes #780.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1257 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 12/6/2020 **Status:** ✅ Merged **Merged:** 12/8/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `cipher-rev-date` --- ### 📝 Commits (1) - [`a9e9a39`](https://github.com/dani-garcia/vaultwarden/commit/a9e9a397d82c9bf7a7bc8aa1413b925f7450a16a) Validate cipher updates with revision date ### 📊 Changes **1 file changed** (+21 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+21 -1) </details> ### 📄 Description Prevent clients from updating a cipher if the local copy is stale. Validation is only performed when the client provides its last known revision date; this date isn't provided when using older clients, or when the operation doesn't involve updating an existing cipher. Fixes #780. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>