[PR #1234] [MERGED] Log proper namespace in the err!() macro #2919

New issue

Closed

opened 2026-03-03 09:08:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:08:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1234
Author: @janost
Created: 11/21/2020
Status: ✅ Merged
Merged: 11/27/2020
Merged by: @dani-garcia

Base: master ← Head: fix-failed-auth-log

📝 Commits (1)

caddf21 Log proper namespace in the err!() macro

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 src/error.rs (+3 -0)

📄 Description

Fixes #1233.

This change makes the err!() macro to log the namespace it was called from instead of bitwarden_rs::error.

I did my best to test a few error cases, however it might have some unintended side effects to error logging. Please let me know if it's broken.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1234 **Author:** [@janost](https://github.com/janost) **Created:** 11/21/2020 **Status:** ✅ Merged **Merged:** 11/27/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `fix-failed-auth-log` --- ### 📝 Commits (1) - [`caddf21`](https://github.com/dani-garcia/vaultwarden/commit/caddf21fca66c8339d01ef238c6cf060eb2090d4) Log proper namespace in the err!() macro ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/error.rs` (+3 -0) </details> ### 📄 Description Fixes #1233. This change makes the `err!()` macro to log the namespace it was called from instead of `bitwarden_rs::error`. I did my best to test a few error cases, however it might have some unintended side effects to error logging. Please let me know if it's broken. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>