mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-25 17:25:57 +03:00
[PR #1175] [CLOSED] Set tcp ports via environment variables in Dockerfile #2908
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#2908
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/1175
Author: @CollectiveMakers
Created: 10/6/2020
Status: ❌ Closed
Base:
master← Head:tcp_ports📝 Commits (3)
a252049set tcp ports via env variables5f2de10set tcp ports via env variablesc2ffba0Merge branch 'master' into tcp_ports📊 Changes
7 files changed (+42 additions, -21 deletions)
View changed files
📝
docker/Dockerfile.j2(+6 -3)📝
docker/amd64/Dockerfile(+6 -3)📝
docker/amd64/Dockerfile.alpine(+6 -3)📝
docker/arm32v6/Dockerfile(+6 -3)📝
docker/arm32v7/Dockerfile(+6 -3)📝
docker/arm32v7/Dockerfile.alpine(+6 -3)📝
docker/arm64v8/Dockerfile(+6 -3)📄 Description
First reason is to allow direct use of dockerfiles on Cloud platforms using same environment variables at all stages (build and run)
Second reason is that binding tcp port numbers lower than 1024 doesn’t allow to run processes as non root user (which is recommended in a security perspective)
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.