[PR #1175] [CLOSED] Set tcp ports via environment variables in Dockerfile #2908

Closed
opened 2026-03-03 09:08:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1175
Author: @CollectiveMakers
Created: 10/6/2020
Status: Closed

Base: masterHead: tcp_ports


📝 Commits (3)

  • a252049 set tcp ports via env variables
  • 5f2de10 set tcp ports via env variables
  • c2ffba0 Merge branch 'master' into tcp_ports

📊 Changes

7 files changed (+42 additions, -21 deletions)

View changed files

📝 docker/Dockerfile.j2 (+6 -3)
📝 docker/amd64/Dockerfile (+6 -3)
📝 docker/amd64/Dockerfile.alpine (+6 -3)
📝 docker/arm32v6/Dockerfile (+6 -3)
📝 docker/arm32v7/Dockerfile (+6 -3)
📝 docker/arm32v7/Dockerfile.alpine (+6 -3)
📝 docker/arm64v8/Dockerfile (+6 -3)

📄 Description

First reason is to allow direct use of dockerfiles on Cloud platforms using same environment variables at all stages (build and run)
Second reason is that binding tcp port numbers lower than 1024 doesn’t allow to run processes as non root user (which is recommended in a security perspective)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1175 **Author:** [@CollectiveMakers](https://github.com/CollectiveMakers) **Created:** 10/6/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `tcp_ports` --- ### 📝 Commits (3) - [`a252049`](https://github.com/dani-garcia/vaultwarden/commit/a2520491a19707f646d71da15eafcaa767d5f0c8) set tcp ports via env variables - [`5f2de10`](https://github.com/dani-garcia/vaultwarden/commit/5f2de109ce692c02eeb03df9d1bdf51c17f7ae43) set tcp ports via env variables - [`c2ffba0`](https://github.com/dani-garcia/vaultwarden/commit/c2ffba072ea64b73d40c7c9d5d397dda7b5f0a62) Merge branch 'master' into tcp_ports ### 📊 Changes **7 files changed** (+42 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `docker/Dockerfile.j2` (+6 -3) 📝 `docker/amd64/Dockerfile` (+6 -3) 📝 `docker/amd64/Dockerfile.alpine` (+6 -3) 📝 `docker/arm32v6/Dockerfile` (+6 -3) 📝 `docker/arm32v7/Dockerfile` (+6 -3) 📝 `docker/arm32v7/Dockerfile.alpine` (+6 -3) 📝 `docker/arm64v8/Dockerfile` (+6 -3) </details> ### 📄 Description First reason is to allow direct use of dockerfiles on Cloud platforms using same environment variables at all stages (build and run) Second reason is that binding tcp port numbers lower than 1024 doesn’t allow to run processes as non root user (which is recommended in a security perspective) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:08:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#2908
No description provided.