[PR #1106] [MERGED] Track favorites on a per-user basis #2883

New issue

Closed

opened 2026-03-03 09:08:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:08:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1106
Author: @jjlin
Created: 8/19/2020
Status: ✅ Merged
Merged: 8/23/2020
Merged by: @dani-garcia

Base: master ← Head: favorites

📝 Commits (3)

0e9eba8 Maximize similarity between MySQL and SQLite/PostgreSQL schemas
f83a8a3 Track favorites on a per-user basis
3bbdbb8 Transfer favorite status for user-owned ciphers

📊 Changes

12 files changed (+258 additions, -40 deletions)

View changed files

➕ migrations/mysql/2020-08-02-025025_add_favorites_table/down.sql (+13 -0)
➕ migrations/mysql/2020-08-02-025025_add_favorites_table/up.sql (+16 -0)
➕ migrations/postgresql/2020-08-02-025025_add_favorites_table/down.sql (+13 -0)
➕ migrations/postgresql/2020-08-02-025025_add_favorites_table/up.sql (+16 -0)
➕ migrations/sqlite/2020-08-02-025025_add_favorites_table/down.sql (+13 -0)
➕ migrations/sqlite/2020-08-02-025025_add_favorites_table/up.sql (+71 -0)
📝 src/api/core/ciphers.rs (+6 -1)
📝 src/db/models/cipher.rs (+45 -3)
📝 src/db/schemas/mysql/schema.rs (+39 -33)
📝 src/db/schemas/postgresql/schema.rs (+7 -1)
📝 src/db/schemas/sqlite/schema.rs (+7 -1)
📝 src/main.rs (+12 -1)

📄 Description

Currently, favorites are tracked at the cipher level. For org-owned ciphers,
this means that if one user sets it as a favorite, it automatically becomes a
favorite for all other users that the cipher has been shared with.

Fixes #885.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1106 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 8/19/2020 **Status:** ✅ Merged **Merged:** 8/23/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `favorites` --- ### 📝 Commits (3) - [`0e9eba8`](https://github.com/dani-garcia/vaultwarden/commit/0e9eba8c8b7e2b3b3ea4793ed71c6c52c6606a96) Maximize similarity between MySQL and SQLite/PostgreSQL schemas - [`f83a8a3`](https://github.com/dani-garcia/vaultwarden/commit/f83a8a36d16eb14c4d2f68f7edf7989bbf7973cb) Track favorites on a per-user basis - [`3bbdbb8`](https://github.com/dani-garcia/vaultwarden/commit/3bbdbb832c975d0c9b3e5573fe2bd5ea66b11015) Transfer favorite status for user-owned ciphers ### 📊 Changes **12 files changed** (+258 additions, -40 deletions) <details> <summary>View changed files</summary> ➕ `migrations/mysql/2020-08-02-025025_add_favorites_table/down.sql` (+13 -0) ➕ `migrations/mysql/2020-08-02-025025_add_favorites_table/up.sql` (+16 -0) ➕ `migrations/postgresql/2020-08-02-025025_add_favorites_table/down.sql` (+13 -0) ➕ `migrations/postgresql/2020-08-02-025025_add_favorites_table/up.sql` (+16 -0) ➕ `migrations/sqlite/2020-08-02-025025_add_favorites_table/down.sql` (+13 -0) ➕ `migrations/sqlite/2020-08-02-025025_add_favorites_table/up.sql` (+71 -0) 📝 `src/api/core/ciphers.rs` (+6 -1) 📝 `src/db/models/cipher.rs` (+45 -3) 📝 `src/db/schemas/mysql/schema.rs` (+39 -33) 📝 `src/db/schemas/postgresql/schema.rs` (+7 -1) 📝 `src/db/schemas/sqlite/schema.rs` (+7 -1) 📝 `src/main.rs` (+12 -1) </details> ### 📄 Description Currently, favorites are tracked at the cipher level. For org-owned ciphers, this means that if one user sets it as a favorite, it automatically becomes a favorite for all other users that the cipher has been shared with. Fixes #885. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>