[PR #1026] [MERGED] Fixes #1022 cloning with attachments #2861

New issue

Closed

opened 2026-03-03 09:08:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:08:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1026
Author: @BlackDex
Created: 6/7/2020
Status: ✅ Merged
Merged: 6/7/2020
Merged by: @dani-garcia

Base: master ← Head: issue-1022

📝 Commits (1)

24c9147 Fixes #1022 cloning with attachments

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/api/core/ciphers.rs (+4 -1)

📄 Description

When a cipher has one or more attachments it wasn't able to be cloned.
This commit fixes that issue.

As a side note:
If someone tried to clone items with attachments using any version before this patch they need to remove the empty entries in there vaults and also remove them else other strange issues could happen.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1026 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 6/7/2020 **Status:** ✅ Merged **Merged:** 6/7/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `issue-1022` --- ### 📝 Commits (1) - [`24c9147`](https://github.com/dani-garcia/vaultwarden/commit/24c914799dc9cb711b4def0c00e99943437c69fe) Fixes #1022 cloning with attachments ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+4 -1) </details> ### 📄 Description When a cipher has one or more attachments it wasn't able to be cloned. This commit fixes that issue. As a side note: If someone tried to clone items with attachments using any version before this patch they need to remove the empty entries in there vaults and also remove them else other strange issues could happen. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>