[PR #932] [MERGED] Fix WebSocket notifications #2829

New issue

Closed

opened 2026-03-03 08:53:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:53:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/932
Author: @jjlin
Created: 3/27/2020
Status: ✅ Merged
Merged: 3/27/2020
Merged by: @dani-garcia

Base: master ← Head: ws-fix

📝 Commits (1)

862d401 Fix WebSocket notifications

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/api/notifications.rs (+6 -2)

📄 Description

Ignore a missing id query param; it's unclear what this ID represents,
but it wasn't being used in the existing bitwarden_rs code, and no longer
seems to be sent in the latest versions of the official clients.

Fixes #929.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/932 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 3/27/2020 **Status:** ✅ Merged **Merged:** 3/27/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `ws-fix` --- ### 📝 Commits (1) - [`862d401`](https://github.com/dani-garcia/vaultwarden/commit/862d4010770766285f63924d74a1e919707ce6be) Fix WebSocket notifications ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/api/notifications.rs` (+6 -2) </details> ### 📄 Description Ignore a missing `id` query param; it's unclear what this ID represents, but it wasn't being used in the existing bitwarden_rs code, and no longer seems to be sent in the latest versions of the official clients. Fixes #929. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>