[PR #928] [MERGED] Healthcheck fixes/optimizations #2828

New issue

Closed

opened 2026-03-03 08:53:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:53:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/928
Author: @jjlin
Created: 3/26/2020
Status: ✅ Merged
Merged: 3/26/2020
Merged by: @dani-garcia

Base: master ← Head: healthcheck

📝 Commits (1)

bbb0484 Healthcheck fixes/optimizations

📊 Changes

14 files changed (+40 additions, -39 deletions)

View changed files

📝 docker/Dockerfile.j2 (+2 -2)
📝 docker/aarch64/mysql/Dockerfile (+3 -3)
📝 docker/aarch64/sqlite/Dockerfile (+3 -3)
📝 docker/amd64/mysql/Dockerfile (+3 -3)
📝 docker/amd64/mysql/Dockerfile.alpine (+3 -3)
📝 docker/amd64/postgresql/Dockerfile (+3 -3)
📝 docker/amd64/postgresql/Dockerfile.alpine (+3 -3)
📝 docker/amd64/sqlite/Dockerfile (+3 -3)
📝 docker/amd64/sqlite/Dockerfile.alpine (+3 -3)
📝 docker/armv6/mysql/Dockerfile (+3 -3)
📝 docker/armv6/sqlite/Dockerfile (+3 -3)
📝 docker/armv7/mysql/Dockerfile (+3 -3)
📝 docker/armv7/sqlite/Dockerfile (+3 -3)
📝 docker/healthcheck.sh (+2 -1)

📄 Description

Switch healthcheck interval/timeout from 30s/3s to 60s/10s.
30s interval is arguably overkill, and 3s timeout is definitely too short
for lower end machines.
Use HEALTHCHECK CMD exec form to avoid superfluous sh invocations.
Add --silent --show-error flags to curl call to avoid progress meter being
shown in healthcheck logs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/928 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 3/26/2020 **Status:** ✅ Merged **Merged:** 3/26/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `healthcheck` --- ### 📝 Commits (1) - [`bbb0484`](https://github.com/dani-garcia/vaultwarden/commit/bbb0484d032b6f268384b51a68b72614d79bb020) Healthcheck fixes/optimizations ### 📊 Changes **14 files changed** (+40 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `docker/Dockerfile.j2` (+2 -2) 📝 `docker/aarch64/mysql/Dockerfile` (+3 -3) 📝 `docker/aarch64/sqlite/Dockerfile` (+3 -3) 📝 `docker/amd64/mysql/Dockerfile` (+3 -3) 📝 `docker/amd64/mysql/Dockerfile.alpine` (+3 -3) 📝 `docker/amd64/postgresql/Dockerfile` (+3 -3) 📝 `docker/amd64/postgresql/Dockerfile.alpine` (+3 -3) 📝 `docker/amd64/sqlite/Dockerfile` (+3 -3) 📝 `docker/amd64/sqlite/Dockerfile.alpine` (+3 -3) 📝 `docker/armv6/mysql/Dockerfile` (+3 -3) 📝 `docker/armv6/sqlite/Dockerfile` (+3 -3) 📝 `docker/armv7/mysql/Dockerfile` (+3 -3) 📝 `docker/armv7/sqlite/Dockerfile` (+3 -3) 📝 `docker/healthcheck.sh` (+2 -1) </details> ### 📄 Description * Switch healthcheck interval/timeout from 30s/3s to 60s/10s. 30s interval is arguably overkill, and 3s timeout is definitely too short for lower end machines. * Use HEALTHCHECK CMD exec form to avoid superfluous `sh` invocations. * Add `--silent --show-error` flags to curl call to avoid progress meter being shown in healthcheck logs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>