[PR #916] [MERGED] Fixing issue #759 by disabling Foreign Key Checks. #2823

Closed
opened 2026-03-03 08:53:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/916
Author: @BlackDex
Created: 3/18/2020
Status: Merged
Merged: 3/18/2020
Merged by: @dani-garcia

Base: masterHead: issue-759


📝 Commits (1)

  • 35f3008 Fixing issue #759 by disabling Foreign Key Checks.

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 src/main.rs (+10 -0)

📄 Description

During migrations some queries are out of order regarding to foreign
keys.
Because of this the migrations fail when the sql database has this
enforced by default.
Turning of this check during the migrations will fix this and this is
only per session.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/916 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 3/18/2020 **Status:** ✅ Merged **Merged:** 3/18/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `issue-759` --- ### 📝 Commits (1) - [`35f3008`](https://github.com/dani-garcia/vaultwarden/commit/35f30088b2fd4f97c39b4af6c4aadecaecffe5a4) Fixing issue #759 by disabling Foreign Key Checks. ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+10 -0) </details> ### 📄 Description During migrations some queries are out of order regarding to foreign keys. Because of this the migrations fail when the sql database has this enforced by default. Turning of this check during the migrations will fix this and this is only per session. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 08:53:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#2823
No description provided.