[PR #900] [CLOSED] Fix escaping of SMTP_AUTH_MECHANISM in .env.template #2816

New issue

Closed

opened 2026-03-03 08:53:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:53:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/900
Author: @sleweke
Created: 3/12/2020
Status: ❌ Closed

Base: master ← Head: fix/env-template

📝 Commits (1)

2bf337d Fix escaping of SMTP_AUTH_MECHANISM in env template

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 .env.template (+1 -1)

📄 Description

Correctly escapes the quotation marks of the SMTP_AUTH_MECHANISM variable in .env.template.
The file is sourced by the shell and swallows the simple quotation marks.
However, we need a proper JSON value, that is, it has to have quotation marks.
Otherwise, we get the error

thread '<unnamed>' panicked at 'Failure to parse mechanism. Is it proper Json? Eg. `"Plain"` not `Plain`', src/mail.rs:52:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is fixed by adding escaped quotation marks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/900 **Author:** [@sleweke](https://github.com/sleweke) **Created:** 3/12/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/env-template` --- ### 📝 Commits (1) - [`2bf337d`](https://github.com/dani-garcia/vaultwarden/commit/2bf337dc280872461b82064a65aa91dc35a0ad86) Fix escaping of SMTP_AUTH_MECHANISM in env template ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+1 -1) </details> ### 📄 Description Correctly escapes the quotation marks of the `SMTP_AUTH_MECHANISM` variable in `.env.template`. The file is sourced by the shell and swallows the simple quotation marks. However, we need a proper JSON value, that is, it has to have quotation marks. Otherwise, we get the error ``` thread '<unnamed>' panicked at 'Failure to parse mechanism. Is it proper Json? Eg. `"Plain"` not `Plain`', src/mail.rs:52:22 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` This is fixed by adding escaped quotation marks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>