mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #457] Add entry to read-only collection: No error message #278
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#278
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SebastianS90 on GitHub (Apr 13, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/457
When I have read-only access to a collection and attempt to edit an entry, then I get an error message on save (which is fine).
But when I add an entry then it reports that it has been saved successfully, even in the log it says
Outcome: Successfor the/api/ciphers/createquery. After reloading the vault, the entry disappears.Server:
mprasil/bitwarden:1.8.0-alpinePS: Thank you so much for this amazing server implementation!
@SebastianS90 commented on GitHub (Apr 13, 2019):
The new entries are saved, but not in any collection and therefore the user cannot see it. You might still want to fail the save action in that case (user has read-only access) to avoid confusion.
@janost commented on GitHub (Apr 14, 2019):
I'm not able to reproduce this issue.
As a user who has RO access to the collection, attempting to add an item into the collection results in these log entries:
The web vault displays an error message ("No rights to modify the collection") and the item doesn't seem to be saved.
Can you please try the latest master build and if the problem still persists, can you please post reproduction steps?
@SebastianS90 commented on GitHub (Apr 15, 2019):
I cannot reproduce it with master anymore. So it probably has been fixed somewhere between the
1.8.0release and current master.