[PR #385] [MERGED] Retry updating revision - fixes #383 #2721

New issue

Closed

opened 2026-03-03 08:36:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:36:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/385
Author: @mprasil
Created: 2/5/2019
Status: ✅ Merged
Merged: 2/5/2019
Merged by: @dani-garcia

Base: master ← Head: update_revision_retry

📝 Commits (5)

bce656c Retry updating revision - fixes #383
bd65c4e Remove superfluous cipher.save() call
1a5ecd4 cipher does not need to be mutable
b3f7394 Do not update revision at the end, as we already did that
637f655 Do not allocate uneccessary Vec

📊 Changes

2 files changed (+8 additions, -7 deletions)

View changed files

📝 src/api/core/ciphers.rs (+2 -3)
📝 src/db/models/user.rs (+6 -4)

📄 Description

This should fix #383 (or any other mass operations that trigger a lot of updates)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/385 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 2/5/2019 **Status:** ✅ Merged **Merged:** 2/5/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `update_revision_retry` --- ### 📝 Commits (5) - [`bce656c`](https://github.com/dani-garcia/vaultwarden/commit/bce656c7876bd33dd8db45966823ff2c5ab60066) Retry updating revision - fixes #383 - [`bd65c4e`](https://github.com/dani-garcia/vaultwarden/commit/bd65c4e312219c3165b6aef92183bc84c082e9ef) Remove superfluous cipher.save() call - [`1a5ecd4`](https://github.com/dani-garcia/vaultwarden/commit/1a5ecd4d4aaa3744b45d8e67c689335959f7cc1b) cipher does not need to be mutable - [`b3f7394`](https://github.com/dani-garcia/vaultwarden/commit/b3f7394c06f78fd0019947d6d82f21fedd7a7db5) Do not update revision at the end, as we already did that - [`637f655`](https://github.com/dani-garcia/vaultwarden/commit/637f655b6fe48fb8312b338d439a548911743057) Do not allocate uneccessary Vec ### 📊 Changes **2 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+2 -3) 📝 `src/db/models/user.rs` (+6 -4) </details> ### 📄 Description This should fix #383 (or any other mass operations that trigger a lot of updates) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>