[PR #323] [MERGED] Send email notifications when invitations are accepted/confirmed #2707

New issue

Closed

opened 2026-03-03 08:36:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:36:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/323
Author: @njfox
Created: 1/3/2019
Status: ✅ Merged
Merged: 1/6/2019
Merged by: @dani-garcia

Base: master ← Head: invite_accepted_email

📝 Commits (6)

43eb064 Replace invite/reinvite email functions with generic send_email
736c0e6 Send emails to inviters/invitees when invites are accepted/confirmed
cec28a8 Update admin page to work with new invitation flow
2f5bdc2 Fix formatting and add vault link to notification emails
7db66f7 Refactor invited_by_email check
0a74e79 Refactor generate_invite_claims, make org_name and org_id optional

📊 Changes

4 files changed (+141 additions, -70 deletions)

View changed files

📝 src/api/admin.rs (+8 -2)
📝 src/api/core/organizations.rs (+50 -40)
📝 src/auth.rs (+22 -2)
📝 src/mail.rs (+61 -26)

📄 Description

This PR sends email notifications to users when their invitee accepts an invitation so they know when to confirm them. It also sends an email to the invitee when they are confirmed, which is the behavior indicated by the web vault when they call the /accept endpoint.

Additionally, I've replaced the specific send_invite function with a generic email sending function. This requires the subject and body to be formatted by the caller instead of the callee, which I think offers some flexibility for sending many different types of email, but I am open to discussion on whether we want to keep this approach.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/323 **Author:** [@njfox](https://github.com/njfox) **Created:** 1/3/2019 **Status:** ✅ Merged **Merged:** 1/6/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `invite_accepted_email` --- ### 📝 Commits (6) - [`43eb064`](https://github.com/dani-garcia/vaultwarden/commit/43eb0643511172ed8a9b134b4aca974c459e1535) Replace invite/reinvite email functions with generic send_email - [`736c0e6`](https://github.com/dani-garcia/vaultwarden/commit/736c0e62f25b17a650a854e4718f337dcd2c895d) Send emails to inviters/invitees when invites are accepted/confirmed - [`cec28a8`](https://github.com/dani-garcia/vaultwarden/commit/cec28a85acab502c060359408e26fafec6e41836) Update admin page to work with new invitation flow - [`2f5bdc2`](https://github.com/dani-garcia/vaultwarden/commit/2f5bdc23f667c4c601c3533eeda72524b7f0d576) Fix formatting and add vault link to notification emails - [`7db66f7`](https://github.com/dani-garcia/vaultwarden/commit/7db66f73f03e577132fabd88a8089bece1549c0f) Refactor invited_by_email check - [`0a74e79`](https://github.com/dani-garcia/vaultwarden/commit/0a74e79ceaf809a8481afb9d97dbba0aef807745) Refactor generate_invite_claims, make org_name and org_id optional ### 📊 Changes **4 files changed** (+141 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+8 -2) 📝 `src/api/core/organizations.rs` (+50 -40) 📝 `src/auth.rs` (+22 -2) 📝 `src/mail.rs` (+61 -26) </details> ### 📄 Description This PR sends email notifications to users when their invitee accepts an invitation so they know when to confirm them. It also sends an email to the invitee when they are confirmed, which is the behavior indicated by the web vault when they call the /accept endpoint. Additionally, I've replaced the specific `send_invite` function with a generic email sending function. This requires the subject and body to be formatted by the caller instead of the callee, which I think offers some flexibility for sending many different types of email, but I am open to discussion on whether we want to keep this approach. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>