mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[GH-ISSUE #446] Unable to delete folders in the web vault #269
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#269
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @magiruuvelvet on GitHub (Mar 26, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/446
I'm unable to delete (empty) folders in the web vault. Clicking on the delete button does nothing at all, no message in console and no requests to the server.
I manually need to delete them from the
folderstable in the SQLite database and restart the server to get rid of unused folders. Renaming works though.Is there a way to debug this properly? Logging is enabled, but no logfile is ever being created.
I'm running bitwarden_rs from the docker image; registration is disabled, websockets are disabled.
Tried browsers:
@dani-garcia commented on GitHub (Mar 26, 2019):
I just tried deleting a newly created empty folder and it works for me. Can you reproduce this from a new user? The steps I followed are: create folder from the plus icon in the left sidebar, select folder from the same sidebar, click pencil icon and then the trashcan in the popup.
If you don't get anything in the browser's console and no request is made, I'm not sure how to debug it otherwise.
@magiruuvelvet commented on GitHub (Mar 27, 2019):
I still couldn't delete any folders, and now I also can't delete the newly created test user within an organization. I managed to get something in the browser log. Maybe my reverse proxy is not configured probably. I also checked my firewall rules and there seems to be a major f*ckup blocking the container network.
I disabled the firewall, but still got the same error in both browsers.
EDIT: I will play around a bit with the log levels to see if I can get something useful out of it.
EDIT2: When I click the user delete or folder delete button, I get this in the log file:
But nothing happens.
Sorry for all the spam, but I now figured out the problem and it seems it is completely client side in my 2 browsers. I tried another clean browser without any hacks and extensions installed and everything works there, so something blocks either JavaScript events, WebSockets or DOM events; I don't know. I will figure this out by myself what is causing the client vault not to work correctly.
I guess you can mark this issue as invalid 😄
@mprasil commented on GitHub (Mar 27, 2019):
Try to disable websocket if you have it enabled. (
WEBSOCKET_ENABLED=false) If your proxy isn't configured properly, but the client thinks that it should use websocket, it tends to misbehave in weird ways.@magiruuvelvet commented on GitHub (Mar 27, 2019):
I have websockets disabled already. Than my only other guess could be the reverse proxy. I'm using Caddy server with the
transparentsetting.It's not that kind of a hassle, when it works with the 3rd browser. It's not like I need to regularly delete folders 😄 All other parts of the web vault works in the other two browsers.
EDIT: I tried different things in my caddy proxy, but waterfox and vivaldi just continue to use websockets, while Qt Web Engine just works.
@mprasil commented on GitHub (Mar 28, 2019):
Can you share your config maybe? Redact the secret parts. Is it similar to this one?
@magiruuvelvet commented on GitHub (Mar 28, 2019):
This is my Caddy config file with websockets disabled:
I changed the config to the link you gave me and enabled websockets again in the container. The websocket is working in every browser. But I still can't delete folders, except in Qt Web Engine. The popup window just doesn't seem to load.
What I noticed though now, with websockets enabled. The deleted folder instantly syncs to the other browsers and disappear there.
@mprasil commented on GitHub (Mar 28, 2019):
This is kinda long stretch, but do the folders contain any special characters? Also did you try to disable all browser addons?
@magiruuvelvet commented on GitHub (Mar 28, 2019):
The name doesn't matter, fails with Unicode and ASCII equally. It indeed works without extensions, which I figured already that some extension is blocking something somewhere.
I have all kinds of security related extensions installed and one of them may act way too paranoid on the web vault.
@XelNika commented on GitHub (Mar 30, 2019):
I had this issue today and found that the deletion modal is being blocked by one of my uBlock Origin lists.
To fix this, whitelist your bitwarden_rs vault address or add your own filter to uBO:
@magiruuvelvet commented on GitHub (Mar 30, 2019):
@XelNika Thanks, that did the trick and the popup now appears.
@mprasil commented on GitHub (Apr 10, 2019):
I think this was resolved thanks to @XelNika suggestion, I'm going to close this, but feel free to reopen if there's still some issue regarding this.