[PR #257] [MERGED] Fixes NFC Response for Mobile Yubikey OTP Login #2689

New issue

Closed

opened 2026-03-03 08:36:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:36:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/257
Author: @Step7750
Created: 11/17/2018
Status: ✅ Merged
Merged: 11/17/2018
Merged by: @dani-garcia

Base: master ← Head: fix-nfc-mobile

📝 Commits (1)

f344dba Fixes NFC Response for Mobile Login

📊 Changes

2 files changed (+15 additions, -2 deletions)

View changed files

📝 src/api/core/two_factor.rs (+2 -2)
📝 src/api/identity.rs (+13 -0)

📄 Description

With Yubikey OTP introduced in #254, it doesn't return whether Nfc should be enabled to the mobile client during login. As a result, the mobile client crashes upon login.

This PR returns the proper NFC value saved by the user in 2FA Yubikey OTP settings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/257 **Author:** [@Step7750](https://github.com/Step7750) **Created:** 11/17/2018 **Status:** ✅ Merged **Merged:** 11/17/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `fix-nfc-mobile` --- ### 📝 Commits (1) - [`f344dba`](https://github.com/dani-garcia/vaultwarden/commit/f344dbaad407d3d3b2255628a09fc28a947a34c1) Fixes NFC Response for Mobile Login ### 📊 Changes **2 files changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor.rs` (+2 -2) 📝 `src/api/identity.rs` (+13 -0) </details> ### 📄 Description With Yubikey OTP introduced in #254, it doesn't return whether Nfc should be enabled to the mobile client during login. As a result, the mobile client crashes upon login. This PR returns the proper NFC value saved by the user in 2FA Yubikey OTP settings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>