[PR #244] [MERGED] Make U2F work with vault 2.4.0 changes #2684

Closed
opened 2026-03-03 08:36:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/244
Author: @RomanHargrave
Created: 11/9/2018
Status: Merged
Merged: 11/9/2018
Merged by: @dani-garcia

Base: masterHead: multiple-u2f


📝 Commits (2)

📊 Changes

2 files changed (+22 additions, -14 deletions)

View changed files

📝 src/api/core/mod.rs (+1 -0)
📝 src/api/core/two_factor.rs (+21 -14)

📄 Description

The Bitwarden API for u2f enrollment changed. Specifically, challenge generate was removed from /api/two-factor/get-u2f in to /api/two-factor/get-u2f-challenge.

Presently, this PR restores the minimal functionality, but the desire is to implement multi-enrollment.

RE: #235


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/244 **Author:** [@RomanHargrave](https://github.com/RomanHargrave) **Created:** 11/9/2018 **Status:** ✅ Merged **Merged:** 11/9/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `multiple-u2f` --- ### 📝 Commits (2) - [`760e0ab`](https://github.com/dani-garcia/vaultwarden/commit/760e0ab805c3e7610777ddad2c7d8392b765c7c6) Initial u2f fix - [`62bc58e`](https://github.com/dani-garcia/vaultwarden/commit/62bc58e1453c885b15d3d56e4c50c985e2b9f4d2) Clean up after u2f endpoint split ### 📊 Changes **2 files changed** (+22 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/mod.rs` (+1 -0) 📝 `src/api/core/two_factor.rs` (+21 -14) </details> ### 📄 Description The Bitwarden API for u2f enrollment changed. Specifically, challenge generate was removed from `/api/two-factor/get-u2f` in to `/api/two-factor/get-u2f-challenge`. Presently, this PR restores the minimal functionality, but the desire is to implement multi-enrollment. RE: #235 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 08:36:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#2684
No description provided.