domains, returns JsonResult, fixes saving Custom Equivalent Domains #2678

New issue

Closed

opened 2026-03-03 08:36:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:36:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/231
Author: @janost
Created: 10/22/2018
Status: ✅ Merged
Merged: 10/22/2018
Merged by: @dani-garcia

Base: master ← Head: fix-save-equivalent-domains

📝 Commits (1)

c32c65d Accept PUT and POST on /settings/domains, returns JsonResult, fixes saving Custom Equivalent Domains

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 src/api/core/mod.rs (+8 -2)

📄 Description

Fixes #230.

It seems the Web Vault actually expects a JSON instead of any empty response too, so I changed that as well. Seems to work as expected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/231 **Author:** [@janost](https://github.com/janost) **Created:** 10/22/2018 **Status:** ✅ Merged **Merged:** 10/22/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `fix-save-equivalent-domains` --- ### 📝 Commits (1) - [`c32c65d`](https://github.com/dani-garcia/vaultwarden/commit/c32c65d367aecec1e3261eae1b52bef8640db643) Accept PUT and POST on /settings/domains, returns JsonResult, fixes saving Custom Equivalent Domains ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/mod.rs` (+8 -2) </details> ### 📄 Description Fixes #230. It seems the Web Vault actually expects a JSON instead of any empty response too, so I changed that as well. Seems to work as expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>