[PR #221] [MERGED] Disable WebSockets negotiation by default #2673

New issue

Closed

opened 2026-03-03 08:36:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:36:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/221
Author: @mprasil
Created: 10/14/2018
Status: ✅ Merged
Merged: 10/15/2018
Merged by: @dani-garcia

Base: master ← Head: ws_disable

📝 Commits (2)

9ecc98c Disable WebSockets negotiation by default
2e7fa64 Do not spawn WS thread if it's disabled

📊 Changes

3 files changed (+31 additions, -12 deletions)

View changed files

📝 README.md (+12 -1)
📝 src/api/notifications.rs (+17 -11)
📝 src/main.rs (+2 -0)

📄 Description

This let's users enable WebSockets by setting the WEBSOCKET_ENABLED variable to true. The reason why I suggest to have this off by default is that for users that won't do that extra proxy configuration this causes issues like the one observed in #203 - essentially breaking the organization functionality in unpredictable way.

Users using WebSockets need to do some extra configuration anyways and while this change will break their configuration, it will not break the core functionality, just the WebSockets won't be used until they turn it back on.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/221 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 10/14/2018 **Status:** ✅ Merged **Merged:** 10/15/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `ws_disable` --- ### 📝 Commits (2) - [`9ecc98c`](https://github.com/dani-garcia/vaultwarden/commit/9ecc98c3ccdb01c6c69765f543100256be5a12c1) Disable WebSockets negotiation by default - [`2e7fa64`](https://github.com/dani-garcia/vaultwarden/commit/2e7fa6440b299d59339e58ec413516104954f7aa) Do not spawn WS thread if it's disabled ### 📊 Changes **3 files changed** (+31 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+12 -1) 📝 `src/api/notifications.rs` (+17 -11) 📝 `src/main.rs` (+2 -0) </details> ### 📄 Description This let's users enable WebSockets by setting the `WEBSOCKET_ENABLED` variable to `true`. The reason why I suggest to have this off by default is that for users that won't do that extra proxy configuration this causes issues like the one observed in #203 - essentially breaking the organization functionality in unpredictable way. Users using WebSockets need to do some extra configuration anyways and while this change will break their configuration, it will not break the core functionality, just the WebSockets won't be used until they turn it back on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>