[PR #213] [MERGED] CollectionCipher::save() and delete() should return QueryResult instead of bool #2667

Closed
opened 2026-03-03 02:20:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/213
Author: @janost
Created: 10/6/2018
Status: Merged
Merged: 10/7/2018
Merged by: @dani-garcia

Base: masterHead: refactor-collectioncipher-save-delete


📝 Commits (1)

  • 5292d38 CollectionCipher::save() and delete() should return QueryResult instead of bool

📊 Changes

3 files changed (+22 additions, -16 deletions)

View changed files

📝 src/api/core/ciphers.rs (+12 -3)
📝 src/api/core/organizations.rs (+4 -1)
📝 src/db/models/collection.rs (+6 -12)

📄 Description

Related to #6.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/213 **Author:** [@janost](https://github.com/janost) **Created:** 10/6/2018 **Status:** ✅ Merged **Merged:** 10/7/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `refactor-collectioncipher-save-delete` --- ### 📝 Commits (1) - [`5292d38`](https://github.com/dani-garcia/vaultwarden/commit/5292d38c739db270fc9b3f41a8d84b9699ffbb30) CollectionCipher::save() and delete() should return QueryResult instead of bool ### 📊 Changes **3 files changed** (+22 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+12 -3) 📝 `src/api/core/organizations.rs` (+4 -1) 📝 `src/db/models/collection.rs` (+6 -12) </details> ### 📄 Description Related to #6. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 02:20:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#2667
No description provided.