[PR #170] [MERGED] Fix editing users in Organization #2649

New issue

Closed

opened 2026-03-03 02:20:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 02:20:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/170
Author: @mprasil
Created: 9/4/2018
Status: ✅ Merged
Merged: 9/4/2018
Merged by: @dani-garcia

Base: master ← Head: org-user-edit

📝 Commits (3)

049aa33 Fix editing users in Organization
db111ae Check properly the user membership in Organization
c58682e Fix the logic in user edditing

📊 Changes

2 files changed (+35 additions, -33 deletions)

View changed files

📝 src/api/core/organizations.rs (+28 -33)
📝 src/db/models/organization.rs (+7 -0)

📄 Description

This fixes multiple issues:

Make sure the user is actually member of organization we're managing.
Fix #163 by allowing admin users to edit other admin users.

The implemented change allows admin users to change collection access for other admin users and themselves. Admin user is however not allowed to promote other users to Admin type or drop Admin privileges for other admin users.
Change user_id dynamic parameters to org_user_id as this better reflects the actual information that's provided.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/170 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 9/4/2018 **Status:** ✅ Merged **Merged:** 9/4/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `org-user-edit` --- ### 📝 Commits (3) - [`049aa33`](https://github.com/dani-garcia/vaultwarden/commit/049aa33f179076a6b1ba3b71351b5d7b95ef4fdc) Fix editing users in Organization - [`db111ae`](https://github.com/dani-garcia/vaultwarden/commit/db111ae2a09f7921a0c81f49cd7538d7002f6139) Check properly the user membership in Organization - [`c58682e`](https://github.com/dani-garcia/vaultwarden/commit/c58682e3fbcf76ffa0e99ae6ab342d8c794ce0a5) Fix the logic in user edditing ### 📊 Changes **2 files changed** (+35 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/organizations.rs` (+28 -33) 📝 `src/db/models/organization.rs` (+7 -0) </details> ### 📄 Description This fixes multiple issues: 1. [Make sure](https://github.com/mprasil/bitwarden_rs/blob/049aa33f179076a6b1ba3b71351b5d7b95ef4fdc/src/api/core/organizations.rs#L481) the user is actually member of organization we're managing. 2. Fix #163 by [allowing](https://github.com/mprasil/bitwarden_rs/blob/049aa33f179076a6b1ba3b71351b5d7b95ef4fdc/src/api/core/organizations.rs#L486-L497) admin users to edit other admin users. The implemented change allows admin users to change collection access for other admin users and themselves. Admin user is however not allowed to promote other users to Admin type or drop Admin privileges for other admin users. 3. Change `user_id` dynamic parameters to `org_user_id` as this better reflects the actual information that's provided. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>