[PR #161] [MERGED] Attachment::save() returns Result instead of bool #2643

Closed
opened 2026-03-03 02:20:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/161
Author: @Baelyk
Created: 8/29/2018
Status: Merged
Merged: 8/29/2018
Merged by: @dani-garcia

Base: masterHead: i6


📝 Commits (1)

  • 3dea4cd Attachment::save() returns Result instead of bool

📊 Changes

2 files changed (+13 additions, -12 deletions)

View changed files

📝 src/api/core/ciphers.rs (+8 -5)
📝 src/db/models/attachment.rs (+5 -7)

📄 Description

Returning a result instead of a bool as per #6


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/161 **Author:** [@Baelyk](https://github.com/Baelyk) **Created:** 8/29/2018 **Status:** ✅ Merged **Merged:** 8/29/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `i6` --- ### 📝 Commits (1) - [`3dea4cd`](https://github.com/dani-garcia/vaultwarden/commit/3dea4cd19e7959d5417fb2d270ffc73688d32ed4) `Attachment::save()` returns Result instead of bool ### 📊 Changes **2 files changed** (+13 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+8 -5) 📝 `src/db/models/attachment.rs` (+5 -7) </details> ### 📄 Description Returning a result instead of a bool as per #6 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 02:20:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#2643
No description provided.