[PR #91] [MERGED] Change number of workers in image, document the setting (fixes #90) #2605

New issue

Closed

opened 2026-03-03 02:19:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 02:19:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/91
Author: @mprasil
Created: 7/18/2018
Status: ✅ Merged
Merged: 7/18/2018
Merged by: @dani-garcia

Base: master ← Head: worker_threads

📝 Commits (1)

06f7bd7 Change number of workers in image, document the setting (fixes #90)

📊 Changes

2 files changed (+16 additions, -0 deletions)

View changed files

📝 Dockerfile (+1 -0)
📝 README.md (+15 -0)

📄 Description

This is setting the number of workers to 10. The issue with the default behavior was that on some systems with low number of cores this leads to very low number of workers (2 * $cpu_cores_number) and poor performance. Especially on cloud instances, that often have just one core.

The default is set somewhat conservatively to 10 as most browsers won't create more than ~8 simultaneous connections to the same domain anyway. The documentation was added to let users know, they can increase this number in case they have large number of users where 10 workers might not be enough.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/91 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 7/18/2018 **Status:** ✅ Merged **Merged:** 7/18/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `worker_threads` --- ### 📝 Commits (1) - [`06f7bd7`](https://github.com/dani-garcia/vaultwarden/commit/06f7bd7c976b78c5e490c03f016c9713026c161f) Change number of workers in image, document the setting (fixes #90) ### 📊 Changes **2 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -0) 📝 `README.md` (+15 -0) </details> ### 📄 Description This is setting the number of workers to 10. The issue with the default behavior was that on some systems with low number of cores this leads to very low number of workers (`2 * $cpu_cores_number`) and poor performance. Especially on cloud instances, that often have just one core. The default is set somewhat conservatively to 10 as most browsers won't create more than ~8 simultaneous connections to the same domain anyway. The documentation was added to let users know, they can increase this number in case they have large number of users where 10 workers might not be enough. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>