[PR #14] [MERGED] Also list shared ciphers in find_by_user #2571

New issue

Closed

opened 2026-03-03 02:19:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 02:19:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/14
Author: @mprasil
Created: 5/11/2018
Status: ✅ Merged
Merged: 5/13/2018
Merged by: @dani-garcia

Base: master ← Head: shared_cipher

📝 Commits (3)

8bed867 Also list shared ciphers in find_by_user
89e5440 Fix duplicate ciphers returned from find_by_user
b0472d7 Delete owned ciphers on account deletion

📊 Changes

3 files changed (+29 additions, -4 deletions)

View changed files

📝 src/api/core/accounts.rs (+1 -1)
📝 src/api/core/ciphers.rs (+1 -1)
📝 src/db/models/cipher.rs (+27 -2)

📄 Description

This splits the find_by_user into two separate functions: find_owned_by_user which retains previous functionality and lists only ciphers directly owned by user and find_by_user which now also lists all ciphers shared with user.

As a result shared ciphers are now visible in user's vault.

There's also small change in the /api/ciphers/purge handler to use the find_owned_by_user instead to only purge user's content and not the shared stuff.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/14 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 5/11/2018 **Status:** ✅ Merged **Merged:** 5/13/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `shared_cipher` --- ### 📝 Commits (3) - [`8bed867`](https://github.com/dani-garcia/vaultwarden/commit/8bed867798f59447b940fbf6c0b1a9d5e45056ad) Also list shared ciphers in find_by_user - [`89e5440`](https://github.com/dani-garcia/vaultwarden/commit/89e544009faaf8e40c6b3983ccd6102b88d4fb47) Fix duplicate ciphers returned from find_by_user - [`b0472d7`](https://github.com/dani-garcia/vaultwarden/commit/b0472d7aabae8e1bb1ba6bd639ffb3280ccc2f36) Delete owned ciphers on account deletion ### 📊 Changes **3 files changed** (+29 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+1 -1) 📝 `src/api/core/ciphers.rs` (+1 -1) 📝 `src/db/models/cipher.rs` (+27 -2) </details> ### 📄 Description This splits the `find_by_user` into two separate functions: `find_owned_by_user` which retains previous functionality and lists only ciphers directly owned by user and `find_by_user` which now also lists all ciphers shared with user. As a result shared ciphers are now visible in user's vault. There's also small change in the `/api/ciphers/purge` handler to use the `find_owned_by_user` instead to only purge user's content and not the shared stuff. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>