mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-25 17:25:57 +03:00
[GH-ISSUE #426] question - how do we change the name given to the token in authy? #250
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#250
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pdarcos on GitHub (Mar 6, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/426
When I use authy with 2FA it shows the name of the account as Bitwarden.
Where is this located in the code so I can change it?
Thanks
@dani-garcia commented on GitHub (Mar 6, 2019):
It's hardcoded into the web vault, here. As it is we can't do much about it.
@pdarcos commented on GitHub (Mar 7, 2019):
Hmm, couldn't we just change that line and on the next where it states "&issuer=Bitwarden"?
Or am I forgetting something?
@mprasil commented on GitHub (Mar 7, 2019):
You are forgetting, that this file is statically served, so any change there would also be static. So it would have to be build-time change.
@pdarcos commented on GitHub (Mar 7, 2019):
Got it. But if we compile the web-vault ourselves with those changes it should work, right?
@mprasil commented on GitHub (Mar 7, 2019):
Yes it will work.
@pdarcos commented on GitHub (Mar 7, 2019):
OK, I'm going to venture into this to see if it works.
I git cloned https://github.com/bitwarden/web.git
Then I started following your instructions here https://github.com/dani-garcia/bitwarden_rs/wiki/Building-binary
I cd into web folder and then I downloaded your v2.8.0.patch and tried to apply it as instructed in the wiki
git apply v2.8.0.patch
error: unrecognized input
I must be missing something. Any ideas?
Thanks
@dani-garcia commented on GitHub (Mar 7, 2019):
Hmm, no idea why that could be happening. Can you chech that the downloaded patch file has the correct encoding and end of line characters? The copy of the patches I have locally are utf8 and use linux-style line feeds.
@mprasil commented on GitHub (Mar 7, 2019):
@pdarcos I think much easier approach would be to grab the pre-built Vault and just do your changes there.
@pdarcos commented on GitHub (Mar 7, 2019):
Thanks @mprasil
I'm going to try that approach since it is indeed much easier. But if it is already pre-built will I still be able to change the strings here ?
@mprasil commented on GitHub (Mar 7, 2019):
I think it should still be possible. At the end of the day it's just a bunch of javascript files and the string has to be somewhere there.
@dani-garcia commented on GitHub (Mar 7, 2019):
Editing the already built vault is not the cleanest way, because the code is already minified, but for a small change like this it should be ok.
You'll need to edit the
main.jsfile, I think. You can use search and replace for the&issuer=Bitwardenandotpauth://totp/Bitwarden:strings.@pdarcos commented on GitHub (Mar 7, 2019):
Thanks guys. Found it in main.js indeed. Gonna change it and see how it works out
@pdarcos commented on GitHub (Mar 7, 2019):
To give feedback.
I ended up applying the patch (there was a typo when I copy/pasted the patch file that I fixed) and building the web-vault from scratch as per your wiki.
now it's built and working fine. The token no longer shows up as bitwarden :) Now if only I could figure out how to add an icon to the entry like cloudflare has (the original bitwarden also has no icon).
@dani-garcia commented on GitHub (Mar 7, 2019):
That depends on the OTP client, in this case Authy. If they don't let you configure it manually, it means they jsust keep an internal list of some popular options, so there isn't much you can do.
@pdarcos commented on GitHub (Mar 8, 2019):
Yeah, that makes total sense.
Thanks for the help guys.
Closing this now