mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #5711] Collections permission issue in organisation #2227
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#2227
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MattiasH97 on GitHub (Mar 19, 2025).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/5711
Vaultwarden Support String
Your environment (Generated via diagnostics page)
Config & Details (Generated via diagnostics page)
Show Config & Details
Environment settings which are overridden: ADMIN_TOKEN
Config:
Vaultwarden Build Version
v.1.33.2
Deployment method
Official Container Image
Custom deployment method
No response
Reverse Proxy
Nginx Proxy Manager, v2.12
Host/Server Operating System
Linux
Operating System Version
Windows 11
Clients
Web Vault
Client Version
No response
Steps To Reproduce
Expected Result
User will be added to the collection while maintaining current permissions as we have not touched it.
Actual Result
User will be added to the collection but clears out all other users access to those collections.
Logs
Screenshots or Videos
No response
Additional Context
Backstory
One of my colleagues had done a big oopsie and added his MFA TOTP for vaultwarden into vaultwarden... He got locked out and suddenly had no way to verify his account. Trust me, he got chastised for using vaultwarden to authenticate vaultwarden.
We revoked his 2fa so that he could login and get setup again. For the organisation he had admin permissions so he could see and manage all collections. Due to 2fa being required his account automatically had his access revoked to the organisation. I went and restored access to the organisation. So far everything behaves as one would expect but soon trails off.
Once his account was back he had user permission without any collections and once I gave him admin again he still did not get any of the collections. The odd part is when I tested giving him manual access to the collections that worked... but for whatever god forsaken reason it decided to remove everyone else's collection access.. for all users.. and I can't for the life of me understand why.
Thankfully we only have a handful of users and I got a very good grasp on what they had access to, but I was able to replicate the issue when I tried to give another user access to all collections manually. Then it reset the collections I had just fixed the permissions for again.
As a whole the system has worked great and honestly this is the first time we have run into any issues besides a few client errors when we pull a new image which have always been resolved by simply updating the client.
As of writing the steps to reproduce I might have figured out what is causing it but wanted it out there in case this is an unexpected behaviour.
I believe it is that it lists no users when you have multiple collections with different user permission. Let's say User A has access to collection 1, 2 and 3, while user B only has collection 2. It lists 0 users in the collection and instead of adding user C to the collections you listed, it will become an absolute value. User C has access to the collections listed and then removing the rest.
Not sure if it is me misunderstanding it when it said "No members added" at the time but I believe this is what happens.
We still have an issue with him not getting access automatically to the collections as admin nor owner.
@JIinfrastructure commented on GitHub (Mar 20, 2025):
same issue here. also version 1.33.2
@MattiasH97 commented on GitHub (Mar 21, 2025):
When testing today, even when I select only one collection and then manage access, it does not list any members even though I know that is not true.
Meaning if I were to 'add' a user to the list, I would nuke the permission for that collection.
@MattiasH97 commented on GitHub (Mar 21, 2025):
I have very fat fingers... this is not solved and I can't re-open
@Erik-Hoffmann commented on GitHub (Mar 24, 2025):
We have the same issue, also using 1.33.2.
@Timshel commented on GitHub (Mar 24, 2025):
For the admin role not granting access to all collections I believe https://github.com/dani-garcia/vaultwarden/pull/5673 should fix it.
@mediocricity commented on GitHub (Apr 15, 2025):
Hey there, are there updates on this? This issue is greatly affecting our productivity since our devs keep getting locked out.
@BlackDex commented on GitHub (Apr 15, 2025):
In what sense? How is creating a group which has collection access for these devs, and assigning these groups not working right now?
@BlackDex commented on GitHub (Apr 15, 2025):
Also, the PR #5673 might solve the issue in a quick way. But in the end, the
access_allfeature should be removed, as this is just not how Bitwarden works anymore and support for this way of working will be difficult in the future with all the separate rolls and collection/group permissions they are using now.@otbutz commented on GitHub (Apr 15, 2025):
I guess because most users are unaware that this is possible? (me included up until right now) 😅
The beta status paired with the known issues warning isn't helping either.
github.com/dani-garcia/vaultwarden@66cf179bca/.env.template (L432-L437)If the groups feature is enabled by default, the whole issue here becomes a nothing burger.
@BlackDex commented on GitHub (Apr 15, 2025):
That might be a good one for the next release, since it now makes it easier to manage everything.