mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #5349] New member shows invited when the email was not sent #2125
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#2125
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @abacef on GitHub (Jan 5, 2025).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/5349
Vaultwarden Support String
Your environment (Generated via diagnostics page)
Config & Details (Generated via diagnostics page)
Show Config & Details
Config:
Vaultwarden Build Version
1.32.7
Deployment method
Official Container Image
Custom deployment method
No response
Reverse Proxy
N/A
Host/Server Operating System
Linux
Operating System Version
Debian
Clients
Web Vault
Client Version
No response
Steps To Reproduce
Fresh deployment with for example an incorrect app password for Gmail SMTP, create an org, add a user, it will send an email but give an error because the app password is wrong, but the members page will show the new member as invited when they are not
Expected Result
The new member is not in the database and not shown as invited
Actual Result
The member is shown as invited
Logs
No response
Screenshots or Videos
No response
Additional Context
No response
@BlackDex commented on GitHub (Jan 5, 2025):
Why shouldn't the Member be in an invited state?
You can always resend the invite from the member page.
@abacef commented on GitHub (Jan 5, 2025):
A definition of invited that makes sense to me is that vaultwarden successfully sent an email to the given email address. When I see that the member is invited I think that the user that was invited has to take action next, but this is not true, in reality the system administrator needs to take action next
@stefan0xC commented on GitHub (Jan 5, 2025):
Well, consider it the other way. We create a temporary user, send the invitation successfully and then there is an error trying to save everything to the database. That would be worse, wouldn't it?
You got an error message that the mail was not sent successfully? Why not contact your system administration then?
@BlackDex commented on GitHub (Jan 5, 2025):
Well, we could do not save the user yet, send the mail and after that save the user. Though not sure if that is possible with the mail invite send. Else we could always delete the user upon error.
But as you mentioned, there is a nice message the sending the mail failed. But it is also a bit strange that the invite screen stays visible and trying to save it again will result in an other message that the user already exist.
@stefan0xC commented on GitHub (Jan 5, 2025):
I think this would be worth exploring. On my system I have a number of invited users that do not work (e.g. because they start with
mailto:or had typos in the mail address). If the user records did not persist when there was an error that would help a lot.@BlackDex commented on GitHub (Jan 5, 2025):
I started on a PR to change this, see #5350
There are still some items to address, since this needs to be done on multiple other locations too.
But i think this should work, it at least works for the member invite via the organization console.