mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-25 17:25:57 +03:00
[GH-ISSUE #4844] Manager Role no long has ability to manage collection access #1998
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#1998
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dwestness on GitHub (Aug 12, 2024).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/4844
Subject of the issue
Manager Role no longer has ability to manage collection access
Deployment environment
Your environment (Generated via diagnostics page)
Steps to reproduce
We recently noticed (after updating to version 1.32.0, but could have existed prior to this version unnoticed) that the Manager role no longer has the ability to view/manage the members of an existing collection. It does appear that this role does permit the creation of a new collection and the assignment of members during creation, but then loses all ability to view/manager post-creation as well.
Expected behaviour
Manager role would be able to view/manager collection members as described in the role description.
Actual behaviour
Each collection under an organization no longer as the "..." 3-dots menu to navigate to the access settings of the collection when signed in with a manager role for the organization
@stefan0xC commented on GitHub (Aug 13, 2024):
Thanks for the report. I believe that this is due to the ongoing deprecation of the Manager role (which Bitwarden has removed in
v2024.7.xcompletely) and switching to a permission system (which we currently don't really have implemented).github.com/dani-garcia/vaultwarden@9eebbf3b9f/src/db/models/organization.rs (L348-L365)In earlier versions not returning the correct permissions did not matter but apparently with
v2024.6.xthe Bitwarden web-vault does not take the Manager role into account anymore (while still having it).@BlackDex commented on GitHub (Aug 14, 2024):
I'm looking into fixing this a.t.m. As this does make it a hard to manage Vaultwarden for some users i think.
@BlackDex commented on GitHub (Aug 14, 2024):
Ok, I think i have a fix ready for this issue via #4860