mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 17:55:58 +03:00
[GH-ISSUE #4176] admin diagnostics page: update badges not consistent #1809
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#1809
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tessus on GitHub (Dec 17, 2023).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/4176
Subject of the issue
Deployment environment
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden:
Steps to reproduce
/admin/diagnosticsExpected behaviour
The badges should look the same.
Actual behaviour
The badges use different color for the font. (background is the same)
Troubleshooting data
Please let me know what the correct badge is: Black or white font?
I can create a PR, unless the devs are really bored....
@BlackDex commented on GitHub (Dec 17, 2023):
Indeed. That should be the same thx for reporting!
@stefan0xC commented on GitHub (Dec 17, 2023):
I think it should be black for both (better contrast). (How does it look in dark mode?)
@Gerardv514 commented on GitHub (Jan 19, 2024):
If the suggestion for the above screenshot is to make the label black text for both, will that also include the other labels on the admin diagnostic page?
I saw the below screenshot from another thread here, and noticed the others are white text.
Or is it just the yellow update badges that will be black text?
@tessus commented on GitHub (Jan 19, 2024):
Yep, just the yellow ones. The green ones are clearly legible with the white text, since green is much darker. With yellow the difference in hue between badge and text is too low.
e.g. the other badges (server installed: Update and Branched) already use black text.
We could have also made the text for all badges white, but I believe that would make the badges less legible.