[GH-ISSUE #280] in rocket 0.4 proxy remote ip has change #148

Closed
opened 2026-03-03 01:25:54 +03:00 by kerem · 1 comment
Owner

Originally created by @TMHBOFH on GitHub (Dec 9, 2018).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/280

Hi,
with rocket 0.4 the function to get the remote ip has change.
Please see the changelog.

Request::remote() returns the actual remote IP, doesn't rewrite.

Use Request::real_ip() or Request::client_ip() to retrieve the IP address from the "X-Real-IP" header if it is present.

Thanks for your great work on this project.
best regards

Originally created by @TMHBOFH on GitHub (Dec 9, 2018). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/280 Hi, with rocket 0.4 the function to get the remote ip has change. Please see the [changelog](https://github.com/SergioBenitez/Rocket/blob/a4dcb0cf4cfd28671bbc8f101a99dfa1a74668b9/CHANGELOG.md). > Request::remote() returns the actual remote IP, doesn't rewrite. > > Use Request::real_ip() or Request::client_ip() to retrieve the IP address from the "X-Real-IP" header if it is present. Thanks for your great work on this project. best regards
kerem 2026-03-03 01:25:54 +03:00
Author
Owner

@dani-garcia commented on GitHub (Dec 9, 2018):

This should be fixed in the latest beta commit, good eye!

<!-- gh-comment-id:445553621 --> @dani-garcia commented on GitHub (Dec 9, 2018): This should be fixed in the latest beta commit, good eye!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#148
No description provided.