mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-25 17:25:57 +03:00
[GH-ISSUE #2889] Missing register endpoint in identity API for upcoming Bitwarden November release #1405
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#1405
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @prettyv on GitHub (Nov 4, 2022).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/2889
Originally assigned to: @BlackDex on GitHub.
Bitwarden has a deprecation notice for the November releases planned for 2022-11-16, upping the Bitwarden server version requirement to
>=1.46.0. Concretely this concerns the two endpoints/identity/accounts/preloginand/identity/accounts/register, which were originally moved from/apiand deprecated in this commit.The
preloginendpoint has already been implemented in the identity module I see, butregisterseems to still be missing, which I assume will lead to issues later in the month for new registrations.@BlackDex commented on GitHub (Nov 4, 2022):
Since the register endpoint can only be accessed via the web-vault, and we try to match the ones we support, the impact will be almost none. Before we will match and update we do need to fix that though.
There are some other fixes we need to do also for export on orgs, which I'm working on atm.
@prettyv commented on GitHub (Nov 5, 2022):
Since the Bitwarden desktop client has an interface for creating an account I assumed that this would use the
registerendpoint as well. Although the UI doesn't communicate clearly if this would create an account via the configured self-hosted server URL or only on official Bitwarden servers (the settings button disappears on the create account page, so that might be an indication towards that). I didn't actively create an account via the client myself yet, so I'm not sure, you may be right.@GeekCornerGH commented on GitHub (Nov 12, 2022):
@BlackDex @prettyv So I tried today, with my 2022.10.1 client. It actually tries to register on the selfhosted instance as long you specified your instance url in the login page, probably higher than low priority then.