mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-25 17:25:57 +03:00
[GH-ISSUE #2671] Disable website icons setting was reset? #1346
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#1346
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sfkpmr on GitHub (Aug 3, 2022).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/2671
Subject of the issue
Back in May I asked about how the website icons setting worked, and disabled it. Today I checked the logs and noticed that it had again downloaded icons, and in the UI I saw that all credentials had had icons downloaded.
Deployment environment
Install method: Docker Compose
vaultwarden:
image: vaultwarden/server
container_name: vaultwarden
environment:
- TZ=${TZ}
- SIGNUPS_ALLOWED=false
volumes:
- ./vaultwarden:/data
security_opt:
- no-new-privileges:true
restart: unless-stopped
Clients used: Web, Android, Chromium add-on
Reverse proxy and version: Caddy 2.5.1
MySQL/MariaDB or PostgreSQL version:
Other relevant details:
Steps to reproduce
Disabled the website icons setting in May, now it's been reset.
Expected behaviour
Settings don't change automatically.
Actual behaviour
Setting changed on its own.
Troubleshooting data
@BlackDex commented on GitHub (Aug 3, 2022):
@sfkpmr may i ask where you changed these settings?
If this was in the web-vault, then those are stored in the local storage/cookies of the browser, and thus if you clear that, or change hosts, or use a different browser, then those settings will not be there. Same for the web-vault theme for example.
@sfkpmr commented on GitHub (Aug 3, 2022):
@BlackDex Yes, I changed the settings at /#/settings/preferences in the web UI.
So, is there no way of setting this permanently?
I found this, can I set DISABLE_ICON_DOWNLOAD=false as an environment variable? Or true in my case.
@BlackDex commented on GitHub (Aug 3, 2022):
Yes, that will prevent at least trying to fetch those icons. It will not prevent the clients from requesting them to download, and thus those requests will still end up into the reverse proxy logs.
But they will not be cached or stored locally.