mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #1909] Unable to share attachments #1104
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#1104
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jrkoiter on GitHub (Aug 16, 2021).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/1909
Subject of the issue
When sharing an item that has one or more attachments, the following error is generated by Vaultwarden: "ciphers should not have any attachments". Result is that a user with whom the item is shared, is able to see the item and its details, but the user does not see any attachments.
Deployment environment
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden:
Install method: Docker image
Clients used: web vault
Reverse proxy and version: nginx/1.18.0 (Ubuntu)
MySQL/MariaDB or PostgreSQL version:
Other relevant details:
Steps to reproduce
Expected behaviour
Expected behaviour is that all users with which an item is shared, can see and access its attachments.
Actual behaviour
User can see the shared item, but there are not attachments. Attachments are still visible for the original owner of the item.
Troubleshooting data
@jjlin commented on GitHub (Aug 17, 2021):
This issue only occurs when you share via "Share Selected". I'll open a PR to fix this shortly, but in the meantime, if you share items individually, it should work fine.
BTW, when you get this error message, it should abort the share. Although the UI may show the item as shared until the next refresh, it's not actually shared.
@jrkoiter commented on GitHub (Aug 17, 2021):
Thanks for the quick reply, you are absolutely right: the items with attachments are not shared, only the ones without. I mixed them up. Sharing them individually does indeed work, thanks for this workaround, and for the quick diagnosis even though my report was not fully correct!