starred/vaultwarden
1
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-04-26 01:35:54 +03:00
Code Issues 39 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #4] When editing the cipher, can't change the folder to "No folder" #1

New issue
Closed
opened 2026-03-03 01:23:39 +03:00 by kerem · 1 comment
kerem commented 2026-03-03 01:23:39 +03:00
Owner
Copy link

Originally created by @mprasil on GitHub (Apr 19, 2018).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/4

When editing cipher that's already in some folder, I can select No folder and click save.

Expected result is, that cipher will no longer be in any folder.

Actual result is, that the folder setting isn't updated.

I think there's extra check for None where it shouldn't be when updating the cipher, so when no folder id is provided in the post data (which is the case of selecting No folder) we don't update it. Might be a simple fix (I did something similar in the move handler) but first need to check if it won't affect some other functionality.

Originally created by @mprasil on GitHub (Apr 19, 2018). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/4 When editing cipher that's already in some folder, I can select `No folder` and click save. Expected result is, that cipher will no longer be in any folder. Actual result is, that the folder setting isn't updated. I think there's extra check for `None` where it shouldn't be when updating the cipher, so when no `folder id` is provided in the post data (which is the case of selecting `No folder`) we don't update it. Might be a simple fix (I did something similar in the move handler) but first need to check if it won't affect some other functionality.
kerem closed this issue 2026-03-03 01:23:39 +03:00
kerem commented 2026-03-03 01:23:40 +03:00
Author
Owner
Copy link

@dani-garcia commented on GitHub (Apr 19, 2018):

Thanks, I didn't notice that!
It should be fixed now with e6b6d7f

<!-- gh-comment-id:382789325 --> @dani-garcia commented on GitHub (Apr 19, 2018): Thanks, I didn't notice that! It should be fixed now with e6b6d7f
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
revert-7033-patch-1
cached-config-operations
test_dylint
1.35.8
1.35.7
1.35.6
1.35.5
1.35.4
1.35.3
1.35.2
1.35.1
1.35.0
1.34.3
1.34.2
1.34.1
1.34.0
1.33.2
1.33.1
1.33.0
1.32.7
1.32.6
1.32.5
1.32.4
1.32.3
1.32.2
1.32.1
1.32.0
1.31.0
1.30.5
1.30.4
1.30.3
1.30.2
1.30.1
1.30.0
1.29.2
1.29.1
1.29.0
1.28.1
1.28.0
1.27.0
1.26.0
1.25.2
1.25.1
1.25.0
1.24.0
1.23.1
1.23.0
1.22.2
1.22.1
1.22.0
1.21.0
1.20.0
1.19.0
1.18.0
1.17.0
1.16.3
1.16.2
1.16.1
1.16.0
1.15.1
1.15.0
1.14.2
1.14.1
1.14
1.13.1
1.13.0
1.12.0
1.11.0
1.10.0
1.9.1
1.9.0
1.8.0
1.7.0
1.6.1
1.6.0
1.5.0
1.4.0
1.3.0
1.2.0
1.1.0
1.0.0
0.13.0
0.12.0
0.11.0
0.10.0
0.9.0
Labels
Clear labels   
SSO

   
Third party

   
better for forum

   
bug

   
bug

   
documentation

   
duplicate

   
enhancement

   
future Vault

   
future Vault

   
future Vault

   
good first issue

   
help wanted

   
low priority

   
notes

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
troubleshooting

   
wontfix
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#1
No description provided.