starred/twofactor_gateway-nextcloud

Fork 0

mirror of https://github.com/nextcloud/twofactor_gateway.git synced 2026-04-25 09:05:55 +03:00

[GH-ISSUE #353] Add php cs fixer config #80

New issue

Closed

opened 2026-02-26 05:32:54 +03:00 by kerem · 6 comments

kerem commented

2026-02-26 05:32:54 +03:00

Owner

Originally created by @ChristophWurst on GitHub (Jun 2, 2020).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/353

See github.com/nextcloud/mail@34b9002e7f for reference. This would ease the contribution of new code.

@cdjenkins @boppy anyone else up for this? Shouldn't take more than like 20min to apply :)

Originally created by @ChristophWurst on GitHub (Jun 2, 2020). Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/353 See https://github.com/nextcloud/mail/commit/34b9002e7f4d5d6eb4e91524e41dd50f37e0cb03 for reference. This would ease the contribution of new code. @cdjenkins @boppy anyone else up for this? Shouldn't take more than like 20min to apply :)

kerem

2026-02-26 05:32:54 +03:00

closed this issue
added the
enhancement

help wanted

technical debt
labels

kerem commented

2026-02-26 05:32:55 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Jun 2, 2020):

Btw also added you to the repo so you directly push your PRs :)

@ChristophWurst commented on GitHub (Jun 2, 2020): Btw also added you to the repo so you directly push your PRs :)

kerem commented

2026-02-26 05:32:55 +03:00

Author

Owner

@boppy commented on GitHub (Jun 2, 2020):

Btw also added you to the repo so you directly push your PRs :)

Wow! That's cool. Thank you! Totally in for some automated tool for corrections.

The first commit after an initial fix might be quite... erm... unsexy though... But let's have a look.

PS: I would nevertheless not push directly... I think a small review + merge by pull request is a good way, but still we can merge PRs then...

@boppy commented on GitHub (Jun 2, 2020): > Btw also added you to the repo so you directly push your PRs :) Wow! That's cool. Thank you! Totally in for some automated tool for corrections. The first commit after an initial fix might be quite... erm... unsexy though... But let's have a look. PS: I would nevertheless not push directly... I think a small review + merge by pull request is a good way, but still we can merge PRs then...

kerem commented

2026-02-26 05:32:55 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Jun 2, 2020):

Yes, of course please always use PRs. Github should reject master pushes anyway :)

@ChristophWurst commented on GitHub (Jun 2, 2020): Yes, of course please always use PRs. Github should reject master pushes anyway :)

kerem commented

2026-02-26 05:32:55 +03:00

Author

Owner

@cdjenkins commented on GitHub (Jun 2, 2020):

@ChristophWurst I'm confused on what you are asking. The scripts part of composer.json does have cs fix commands

@cdjenkins commented on GitHub (Jun 2, 2020): @ChristophWurst I'm confused on what you are asking. The scripts part of `composer.json` does have cs fix commands

kerem commented

2026-02-26 05:32:56 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Jun 3, 2020):

By bad! I forgot about https://github.com/nextcloud/twofactor_gateway/pull/338. It's indeed there already. I'm sorry for the confusion caused.

@ChristophWurst commented on GitHub (Jun 3, 2020): By bad! I forgot about https://github.com/nextcloud/twofactor_gateway/pull/338. It's indeed there already. I'm sorry for the confusion caused.

kerem commented

2026-02-26 05:32:56 +03:00

Author

Owner

@cdjenkins commented on GitHub (Jun 3, 2020):

No worries

@cdjenkins commented on GitHub (Jun 3, 2020): No worries

kerem referenced this issue

2026-02-26 05:33:55 +03:00

[PR #80] [MERGED] Bump webpack from 4.16.4 to 4.16.5 #197

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#80

No description provided.

Rows
Columns