starred/twofactor_gateway-nextcloud

Fork 0

mirror of https://github.com/nextcloud/twofactor_gateway.git synced 2026-04-25 09:05:55 +03:00

[GH-ISSUE #358] Hide not configured gateways for users #79

New issue

Open

opened 2026-02-26 05:32:54 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 05:32:54 +03:00

Owner

Originally created by @robrec on GitHub (Jul 2, 2020).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/358

i cant find anything in the administrator documentation, so i hope to find answers here :)

i want to "not showup" the not configured gateways in settings/user/security

Is there a way already builtin? Thanks!!

Originally created by @robrec on GitHub (Jul 2, 2020). Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/358 i cant find anything in the administrator documentation, so i hope to find answers here :) i want to "not showup" the not configured gateways in settings/user/security Is there a way already builtin? Thanks!!

kerem added the

enhancement

help wanted

1. to develop

labels

2026-02-26 05:32:54 +03:00

kerem commented

2026-02-26 05:32:55 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Jul 2, 2020):

I thought this is a known issue but apparently nobody reported it.

So, yeah, I know about this. There is no setting right now.

Any help with an implementation is welcome. This is purely a community app.

@ChristophWurst commented on GitHub (Jul 2, 2020): I thought this is a known issue but apparently nobody reported it. So, yeah, I know about this. There is no setting right now. Any help with an implementation is welcome. This is purely a community app.

kerem commented

2026-02-26 05:32:55 +03:00

Author

Owner

@kffl commented on GitHub (Oct 16, 2021):

I've briefly looked into this issue and it seems somewhat problematic to implement as the Vue component in personal settings only controls what is below the 2FA provider name and icon wrapped in an h3 tag and rendered server-side in apps/settings/templates/settings/personal/security/twofactor.php. Also, the way IProvider interface only supports determining whether a given 2FA provider is enabled for a given user and doesn't contain additional state indicating that a given method is configured/unconfigured, based on which personal settings of that method could be conditionally omitted. Given those entanglements, I have found 3 potential solutions to implement such functionality:

Marking each top-level DOM element controlled by the Vue component with an appropriate CSS class if the gateway that it represents is unconfigured and creating a separate JS script which removes their parent elements once the page loads. I've already implemented that and it seems to be working fine: github.com/kffl/twofactor_gateway@ec378ef8db, but it's a rather hacky solution.
Conditionally adding/removing <provider> entries from info.xml based on occ commands used to configure various gateways offered by this app. Unfortunately, code that re-writes itself (even if it's XML) is a bad pattern and I would be more inclined to accept such a hacky solution on the frontend rather than on the backend, especially given the fact that this is a security-oriented app.
Splitting this app into three separate ones: SMS, Signal and Telegram 2FA Providers. While I'm aware of the state of this project as described in #454, it seems to be the cleanest solution, although requiring additional maintenance efforts.

Would love to hear your feedback. Perhaps I'm still missing something.

@kffl commented on GitHub (Oct 16, 2021): I've briefly looked into this issue and it seems somewhat problematic to implement as the Vue component in personal settings only controls what is below the 2FA provider name and icon wrapped in an h3 tag and rendered server-side in `apps/settings/templates/settings/personal/security/twofactor.php`. Also, the way `IProvider` interface only supports determining whether a given 2FA provider is enabled for a given user and doesn't contain additional state indicating that a given method is configured/unconfigured, based on which personal settings of that method could be conditionally omitted. Given those entanglements, I have found 3 potential solutions to implement such functionality: 1. Marking each top-level DOM element controlled by the Vue component with an appropriate CSS class if the gateway that it represents is unconfigured and creating a separate JS script which removes their parent elements once the page loads. I've already implemented that and it seems to be working fine: https://github.com/kffl/twofactor_gateway/commit/ec378ef8dbceabc168d2a496cb52c1503874b487, but it's a rather hacky solution. 2. Conditionally adding/removing `<provider>` entries from info.xml based on `occ` commands used to configure various gateways offered by this app. Unfortunately, code that re-writes itself (even if it's XML) is a bad pattern and I would be more inclined to accept such a hacky solution on the frontend rather than on the backend, especially given the fact that this is a security-oriented app. 3. Splitting this app into three separate ones: SMS, Signal and Telegram 2FA Providers. While I'm aware of the state of this project as described in #454, it seems to be the cleanest solution, although requiring additional maintenance efforts. Would love to hear your feedback. Perhaps I'm still missing something.

kerem referenced this issue

2026-02-26 05:33:55 +03:00

[PR #79] [MERGED] Bump vue-loader from 14.2.2 to 15.2.7 #195

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#79

No description provided.

Rows
Columns