mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 09:05:55 +03:00
[GH-ISSUE #312] twofactor_gateway causes error accessing admin overview #71
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#71
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nate2014jatc on GitHub (Dec 22, 2019).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/312
Warning, WALL OF TEXT.
This is an entry from my nextcloud log;
@ChristophWurst commented on GitHub (Jan 7, 2020):
And this doesn't happen when you disable the app?
I'd say this is a conflict in the composer dependencies of server and this app. But I'll need more info to debug.
@piti-diablotin commented on GitHub (Jan 18, 2020):
Hi,
I do have the same issue with NC16. Everything seems ok with NC17
If this is a composer conflict, I do not know how to solve it ? Maybe upgrading to NC17 is the easiest way :)
Edit: Googling the guzzle issue it seems to be a loading problem of guzzle. Solutions suggest to require the autoload.php file which is already the case... back to the conflict then
@SimJoSt commented on GitHub (Jan 18, 2020):
@ChristophWurst I am experiencing this aswell. What Information would you need to debug the issue?
Edit: I can confirm the issue doesn't arise with NC17 and v0.15.1 of the app.
@ChristophWurst commented on GitHub (Jan 21, 2020):
Okay, looks like it's the usual suspect: Guzzle. Apparently https://packagist.org/packages/irazasyed/telegram-bot-sdk pulls in Guzzle. And so does Nextcloud. In some cases this is fine, in others this causes huge problems. We've also seen this in https://github.com/christophwurst/nextcloud_sentry.
They have to decouble the http client from the telegram SDK, otherwise this is very hard to avoid. There is an existing ticket https://github.com/irazasyed/telegram-bot-sdk/issues/61 but it's old and with no real outcome.
So, would anyone be interested in digging deeper? As in, opening a bug report upstream to ask for a HTTPlug/PSR7 migration instead of the hard dependency on Guzzle? Then we can use https://packagist.org/packages/christophwurst/nextcloud-http-client here and everything should run smooth with Nextcloud 19+ at least.
@ChristophWurst commented on GitHub (Jan 21, 2020):
Alternatively we can migrate to another Telegram lib or build the requests ourselves. https://packagist.org/packages/telegram-bot/api is one without a guzzle dependency that I could find
@nate2014jatc commented on GitHub (Sep 5, 2020):
Has this gained any traction?
I stumbled by and noticed that the tag was still "Needs Info" despite the issue being tracked down and suggestions for fixes being made.
@ChristophWurst commented on GitHub (Sep 7, 2020):
No, it has not