mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 09:05:55 +03:00
[GH-ISSUE #302] sms77io not selectable #70
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#70
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itverwaltung on GitHub (Dec 12, 2019).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/302
In version 15 smsio is supported as a twofactor gateway provider.
www-data@svrhnextcloud:/var/www/nextcloud$ php occ twofactorauth:gateway:configure sms
Please choose a SMS provider (websms, playsms, clockworksms, puzzelsms, ecallsms, voipms, huawei_e3531, spryng):
sms77io is not listed... How can i use this provider?
www-data@svrhnextcloud:/var/www/nextcloud$ php occ app:list | grep twofactor_gateway
So version 15 is installed ...
Thank you for any advice..
Alex
@ChristophWurst commented on GitHub (Dec 12, 2019):
Hi Alex,
enter 'sms77' ;)
It's just missing in the help text at
github.com/nextcloud/twofactor_gateway@c7a23e6eb7/lib/Command/Configure.php (L108). Mind submitting a pull request to add it? That would be awesome!Cheers and thanks for the feedback.
@itverwaltung commented on GitHub (Dec 12, 2019):
Hi Christoph,
i did as you said, but no luck:
www-data@svrhnextcloud:/var/www/nextcloud$ php occ twofactorauth:gateway:configure sms
Please choose a SMS provider (websms, playsms, clockworksms, puzzelsms, ecallsms, voipms, huawei_e3531, spryng): sms77
In ProviderFactory.php line 59:
Provider does not exist
twofactorauth:gateway:configure
www-data@svrhnextcloud:/var/www/nextcloud$
Any further hints?
Thank you!
Kind regards
Alex
@ChristophWurst commented on GitHub (Dec 12, 2019):
Correct. There is another bug 🙈
Please submit another PR that changes
github.com/nextcloud/twofactor_gateway@c7a23e6eb7/lib/Command/Configure.php (L239)to 'sms77io'. Then it should work.(ref
github.com/nextcloud/twofactor_gateway@c7a23e6eb7/lib/Service/Gateway/SMS/Provider/Sms77Io.php (L33))@itverwaltung commented on GitHub (Dec 13, 2019):
I tried to make a fork, a branch, edited the file, commited, and made a pull request. First time, have mercy ...
@ChristophWurst commented on GitHub (Dec 13, 2019):
No worries. We all started there :)
The DCO check failed. You might have to rebase the commits locally. Let me knew if you need help. You'll also find useful information at https://help.github.com/en/github
@nursoda commented on GitHub (Jan 18, 2020):
Christoph, seriously? We are users (or admins) but not all of us are devs. For us it's hard enough to post decent bug reports. But requesting multiple PR from an oviously non-dev where it would have been two tiny code changes you already looked up seems insane to me.
@ChristophWurst commented on GitHub (Jan 20, 2020):
Wow, wait a sec. This app is a community effort. There is no obligation for anyone to maintain this project.
I've been very permissive towards the many community PRs that add support for edge case gateways. There is no way for me to test them, nor maintain it in a way that I would know if they work.
If you need enterprise support for this app you can check out https://nextcloud.com/enterprise/. But otherwise this is and will remain a community app.
Doing the maintenance of managing PRs, triaging issues and helping with problems is the most I can do. The change is minimal. But it takes me as much time as it would take you.
@ChristophWurst commented on GitHub (Jan 20, 2020):
And you don't have to code yourself if you're not a programmer. Just ask or hire someone to do it if it's important.
@nursoda commented on GitHub (Jan 20, 2020):
Fair enough. Thanks for committing. I confirm that sms77.io works fine :-)